Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repurpose the "Animatable CSS properties" page #26364

Merged
merged 14 commits into from
Apr 24, 2023

Conversation

yarusome
Copy link
Contributor

@yarusome yarusome commented Apr 22, 2023

Description

This PR:

  1. Reuses the existing "Animatable CSS properties" page to adds contents to explain the common animation types;
  2. Has not edited the following affected pages that link to this page:
    • web/css/animation,
    • web/css/css_transitions/using_css_transitions,
    • web/css/transition-property;
  3. Does not remove the to-be-deprecated {{CSSAnimatedProperties}} macro.

Motivation

See https://github.com/orgs/mdn/discussions/367.

Additional details

Most contents are reproduced from the relevant section in the Web Animations spec:
https://w3c.github.io/csswg-drafts/web-animations-1/#animating-properties

Related issues and pull requests

Fixes #17768.

@github-actions github-actions bot added the Content:CSS Cascading Style Sheets docs label Apr 22, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Apr 22, 2023

Preview URLs

External URLs (3)

URL: /en-US/docs/Web/CSS/CSS_animated_properties
Title: Animatable CSS properties

(comment last updated: 2023-04-24 13:58:16)

@yarusome yarusome marked this pull request as ready for review April 22, 2023 16:29
@yarusome yarusome requested a review from a team as a code owner April 22, 2023 16:29
@yarusome yarusome requested review from estelle and removed request for a team April 22, 2023 16:29
@yarusome
Copy link
Contributor Author

cc @teoli2003

Copy link
Contributor

@teoli2003 teoli2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few changes needed (We'll need to check the output of the PR companion to check the output of the definition list)

files/en-us/web/css/css_animated_properties/index.md Outdated Show resolved Hide resolved
@@ -1,15 +1,53 @@
---
title: Animatable CSS properties
title: Animating CSS properties
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer to keep the page's name as is for now. If we want to change it, we should move the page too. This can be done in a follow-up PR to keep the discussion separated.

files/en-us/web/css/css_animated_properties/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/css_animated_properties/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/css_animated_properties/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/css_animated_properties/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/css_animated_properties/index.md Outdated Show resolved Hide resolved
yarusome and others added 10 commits April 24, 2023 20:32
Co-authored-by: Jean-Yves Perrier <jypenator@gmail.com>
Co-authored-by: Jean-Yves Perrier <jypenator@gmail.com>
Co-authored-by: Jean-Yves Perrier <jypenator@gmail.com>
Co-authored-by: Jean-Yves Perrier <jypenator@gmail.com>
Co-authored-by: Jean-Yves Perrier <jypenator@gmail.com>
@yarusome yarusome requested a review from teoli2003 April 24, 2023 14:02
@yarusome
Copy link
Contributor Author

I finally fixed the definition list after finding the format in the guide.

Copy link
Contributor

@teoli2003 teoli2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:CSS Cascading Style Sheets docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing info about different animation types
2 participants