Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(template): Add template for CSS module landing pages #27731

Merged
merged 7 commits into from
Jul 10, 2023

Conversation

dipikabh
Copy link
Contributor

@dipikabh dipikabh commented Jul 4, 2023

Description

This PR is related to the work being done via openwebdocs/project#147 by @estelle.

Motivation

To define a structure that can be used uniformly to create/update other CSS module landing pages.

Additional details

  • The template in this PR proposes to elevate the "x in action" section to H2 so that it is available from the in-page "In this article" TOC. If this gets accepted, I can update the module landing pages that have already been worked on.
  • Similarly, I can go back to check the 'done' module landing pages to see compliance with the template.

@dipikabh dipikabh requested a review from a team as a code owner July 4, 2023 02:20
@dipikabh dipikabh requested review from hamishwillee and removed request for a team July 4, 2023 02:20
@github-actions github-actions bot added the Content:Meta Content in the meta docs label Jul 4, 2023
@dipikabh dipikabh requested a review from estelle July 4, 2023 02:21
@github-actions
Copy link
Contributor

github-actions bot commented Jul 4, 2023

@sideshowbarker sideshowbarker added the Content:CSS Cascading Style Sheets docs label Jul 4, 2023
@@ -129,6 +129,27 @@ An **SVG reference page** lists all the attributes that are available on an SVG

- [SVG element page template](/en-US/docs/MDN/Writing_guidelines/Page_structures/Page_types/SVG_element_page_template)

## CSS module landing page

Every **[CSS](/en-US/docs/Web/CSS) module** links to a specification that provides support for certain features and implementations in CSS. For example, the specification linked to the [CSS box model](/en-US/docs/Web/CSS/CSS_box_model) module describes the margin and padding properties that let you create spacing in and around a CSS box.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Every **[CSS](/en-US/docs/Web/CSS) module** links to a specification that provides support for certain features and implementations in CSS. For example, the specification linked to the [CSS box model](/en-US/docs/Web/CSS/CSS_box_model) module describes the margin and padding properties that let you create spacing in and around a CSS box.
Every **[CSS](/en-US/docs/Web/CSS) module** links to a specification that provides support for certain features and implementations in CSS. For example, the specification linked to the [CSS box model](/en-US/docs/Web/CSS/CSS_box_model) module describes the margin and padding properties defined in the CSS box model specification that let you create spacing in and around a CSS box.

just want to somehow say a module is a specification, with css1 and css2.X specs not included

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^^^ Not quite right "the specification linked to" and "defined in the CSS box model specification" in the same sentence.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modified the text a bit to add clarity. Is this better (efb00cd)?

Every CSS module represents a CSS specification that provides support for certain features and implementations in CSS. For example, the CSS box model module represents the specification that describes the margin and padding properties that let you create spacing in and around a CSS box.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds good

Copy link
Member

@estelle estelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two suggested things to add, but approving because it's also ok as is.

@github-actions github-actions bot removed the Content:CSS Cascading Style Sheets docs label Jul 10, 2023
@@ -45,7 +45,7 @@ If the work is more significant, then you should consider a few factors when pri

If you want to get a team together to work on an update, or you just want to report or discuss some content needing an update, feel free to [file a content issue](https://github.com/mdn/content/issues) or [ask us for help](/en-US/docs/MDN/Community/Communication_channels).

## The page-type front matter key
## Front matter key for page types
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why? Given the important subject here is page-type?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wanted to get rid of the "The" at the beginning of the title. Also because we're not referring to any other front matter keys, it seemed this could be made a bit generic. Reverting in d126142.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's OK either way. I prefer it the way you reverted, but that doesn't make me right.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries! I value your input and didn't want to disturb the reasoning that's gone behind the page type page creation. All good. 👍

A **CSS module landing page** provides an overview of the features that the module provides and lists all the properties, data types, CSS functions, and so on offered by the module. When possible, the CSS module landing page also provides a quick demonstration of what can be achieved using the properties of the module through an interactive example.
The module landing page serves primarily as a _navigation_ page, but also functions as an at-a-glance _reference_ page for the module.

Some related properties and features that belong in other modules but are closely related to the functionality offered by the module you are documenting can also be covered in a _Related concepts_ section.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Some related properties and features that belong in other modules but are closely related to the functionality offered by the module you are documenting can also be covered in a _Related concepts_ section.
Some related properties and features that belong in other modules, but which are closely related to the functionality offered by the module you are documenting, can also be covered in a _Related concepts_ section.

A **CSS module landing page** provides an overview of the features that the module provides and lists all the properties, data types, CSS functions, and so on offered by the module. When possible, the CSS module landing page also provides a quick demonstration of what can be achieved using the properties of the module through an interactive example.
The module landing page serves primarily as a _navigation_ page, but also functions as an at-a-glance _reference_ page for the module.

Some related properties and features that belong in other modules but are closely related to the functionality offered by the module you are documenting can also be covered in a _Related concepts_ section.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Some related properties and features that belong in other modules but are closely related to the functionality offered by the module you are documenting can also be covered in a _Related concepts_ section.
Some related properties and features that belong in other modules, but which are closely related to the functionality offered by the module you are documenting, can also be covered in a _Related concepts_ section.

@dipikabh
Copy link
Contributor Author

Thanks a lot @estelle and @hamishwillee for reviewing these template changes. Let me know what you think of the updates based on your feedback.

Copy link
Collaborator

@hamishwillee hamishwillee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good. Estelle has already approved and noted she was happy, so merging.

@hamishwillee hamishwillee merged commit bfdfe97 into mdn:main Jul 10, 2023
6 checks passed
@dipikabh
Copy link
Contributor Author

Thanks, Hamish!

@dipikabh dipikabh deleted the css-modland-template branch July 12, 2023 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:Meta Content in the meta docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants