New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSS property update: counter-increment #29688

Merged

dipikabh merged 8 commits into mdn:main from estelle:counterstyles

Oct 24, 2023

Member

estelle commented Oct 17, 2023 •

edited

Loading

Updated content
Added useful example
Moved existing "example" (sample code) to syntax section.
part of openwebdocs/project#183


          CSS property update: counter-increment

c93382b

estelle requested a review from a team as a code owner

October 17, 2023 23:13

estelle requested review from dipikabh and removed request for a team

October 17, 2023 23:13

github-actions bot added the Content:CSS label

Contributor

github-actions bot commented Oct 17, 2023 •

edited

Loading

Preview URLs

/en-US/docs/Web/CSS/counter-increment

(comment last updated: 2023-10-24 01:47:06)


          added module

8c13106

dipikabh self-assigned this

dipikabh requested changes

View reviewed changes

Contributor

dipikabh left a comment

Thanks for the PR, @estelle. I've added my suggestions.

Using increase/decrease instead of increment/decrement might be easier for a wider audience to understand (might help with translations as well).

files/en-us/web/css/counter-increment/index.md Outdated Show resolved Hide resolved

files/en-us/web/css/counter-increment/index.md Outdated Show resolved Hide resolved

files/en-us/web/css/counter-increment/index.md Outdated Show resolved Hide resolved

files/en-us/web/css/counter-increment/index.md Outdated Show resolved Hide resolved

files/en-us/web/css/counter-increment/index.md Show resolved Hide resolved

files/en-us/web/css/counter-increment/index.md Outdated Show resolved Hide resolved

files/en-us/web/css/counter-increment/index.md Outdated Show resolved Hide resolved

files/en-us/web/css/counter-increment/index.md Outdated Show resolved Hide resolved

files/en-us/web/css/counter-increment/index.md Outdated Show resolved Hide resolved

files/en-us/web/css/counter-increment/index.md Outdated Show resolved Hide resolved


          Apply suggestions from code review

c2446e7

Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>

github-actions bot reviewed

View reviewed changes

files/en-us/web/css/counter-increment/index.md Outdated Show resolved Hide resolved

estelle and others added 2 commits

October 19, 2023 17:10


          Update files/en-us/web/css/counter-increment/index.md

8ce29d3

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>


          remove 3 lines. Add one line back in

be8f382

Member Author

estelle commented Oct 20, 2023

Thanks for the review @dipikabh

estelle requested a review from dipikabh

October 20, 2023 00:16

dipikabh reviewed

View reviewed changes

files/en-us/web/css/counter-increment/index.md Outdated Show resolved Hide resolved

files/en-us/web/css/counter-increment/index.md Show resolved Hide resolved

files/en-us/web/css/counter-increment/index.md Show resolved Hide resolved

dipikabh requested changes

View reviewed changes

Contributor

dipikabh left a comment

Thanks, @estelle. There's a few last things that can be improved.

files/en-us/web/css/counter-increment/index.md Outdated Show resolved Hide resolved

files/en-us/web/css/counter-increment/index.md Outdated Show resolved Hide resolved

files/en-us/web/css/counter-increment/index.md Outdated Show resolved Hide resolved

files/en-us/web/css/counter-increment/index.md Outdated Show resolved Hide resolved


          Apply suggestions from code review

2155ac9

Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>

estelle requested a review from dipikabh

October 23, 2023 22:06

Member Author

estelle commented Oct 23, 2023

@dipikabh Thanks for the review

github-actions bot reviewed

View reviewed changes

files/en-us/web/css/counter-increment/index.md Outdated Show resolved Hide resolved


          Update files/en-us/web/css/counter-increment/index.md

c2105f1

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

dipikabh approved these changes

View reviewed changes

Contributor

dipikabh left a comment

Thank you 👍

dipikabh requested changes

View reviewed changes

files/en-us/web/css/counter-increment/index.md Outdated Show resolved Hide resolved


          removes extra line

2a483b9

dipikabh approved these changes

View reviewed changes

dipikabh merged commit a4c88a5 into mdn:main

6 checks passed

estelle deleted the counterstyles branch

December 5, 2023 18:37

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels