Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSS modules: Symbols descriptor and function #29707

Merged
merged 8 commits into from
Nov 1, 2023
Merged

CSS modules: Symbols descriptor and function #29707

merged 8 commits into from
Nov 1, 2023

Conversation

estelle
Copy link
Member

@estelle estelle commented Oct 18, 2023 •
edited
Loading

update the symbols descriptor page and the symbols() function, as part of the css module rewrite.
part of openwebdocs/project#181

@estelle estelle requested a review from a team as a code owner October 18, 2023 17:38
@estelle estelle requested review from dipikabh and removed request for a team October 18, 2023 17:38
@github-actions github-actions bot added the Content:CSS Cascading Style Sheets docs label Oct 18, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 18, 2023 •
edited
Loading

Preview URLs

(comment last updated: 2023-10-31 19:58:59)

@dipikabh dipikabh self-assigned this Oct 18, 2023
dipikabh
dipikabh requested changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@dipikabh dipikabh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @estelle! Added a few edit suggestions.

files/en-us/web/css/symbols/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/symbols/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/@counter-style/symbols/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/@counter-style/symbols/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/@counter-style/symbols/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/@counter-style/symbols/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/@counter-style/symbols/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/@counter-style/symbols/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/@counter-style/symbols/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/@counter-style/symbols/index.md Show resolved Hide resolved
estelle and others added 2 commits October 30, 2023 12:29
@estelle @dipikabh
Apply suggestions from code review
1bcdcf6 
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
@estelle
address feedback
2632a35
@estelle
Copy link
Member Author

estelle commented Oct 30, 2023

Thanks @dipikabh. I think (hope) we're good to go!

@estelle estelle requested a review from dipikabh October 30, 2023 22:52
dipikabh
dipikabh approved these changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@dipikabh dipikabh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 👍

dipikabh
dipikabh requested changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@dipikabh dipikabh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just noticed the preview page. The DL will need fixing.

files/en-us/web/css/@counter-style/symbols/index.md Show resolved Hide resolved
@estelle estelle requested a review from dipikabh October 31, 2023 19:55
dipikabh
dipikabh approved these changes Nov 1, 2023
View reviewed changes
Copy link
Contributor

@dipikabh dipikabh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dipikabh dipikabh merged commit 31e2290 into mdn:main Nov 1, 2023
6 checks passed
@estelle estelle deleted the symbols branch December 5, 2023 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dipikabh dipikabh dipikabh approved these changes

Assignees

@dipikabh dipikabh

Labels
Content:CSS Cascading Style Sheets docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@estelle @dipikabh