Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Counter descriptor: pad #29820

Merged
merged 4 commits into from
Oct 27, 2023
Merged

Counter descriptor: pad #29820

merged 4 commits into from
Oct 27, 2023

Conversation

estelle
Copy link
Member

@estelle estelle commented Oct 24, 2023

@estelle estelle requested a review from a team as a code owner October 24, 2023 20:55
@estelle estelle requested review from dipikabh and removed request for a team October 24, 2023 20:55
@github-actions github-actions bot added the Content:CSS Cascading Style Sheets docs label Oct 24, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 24, 2023 •
edited
Loading

Preview URLs

(comment last updated: 2023-10-26 17:52:58)

dipikabh
dipikabh requested changes Oct 26, 2023
View reviewed changes
Copy link
Contributor

@dipikabh dipikabh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these updates, @estelle!

files/en-us/web/css/@counter-style/pad/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/@counter-style/pad/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/@counter-style/pad/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/@counter-style/pad/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/@counter-style/pad/index.md Show resolved Hide resolved
files/en-us/web/css/@counter-style/pad/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/@counter-style/pad/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/@counter-style/pad/index.md Outdated Show resolved Hide resolved
@dipikabh dipikabh self-assigned this Oct 26, 2023
@estelle @dipikabh
Apply suggestions from code review
80d03d7 
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
@estelle
Copy link
Member Author

estelle commented Oct 26, 2023

@dipikabh Thanks for the review. Suggested edits are committed, I update the syntax with a reverse order, and the link to symbol now works (the description of symbol was merged earlier this week)

@estelle estelle requested a review from dipikabh October 26, 2023 17:52
dipikabh
dipikabh approved these changes Oct 27, 2023
View reviewed changes
Copy link
Contributor

@dipikabh dipikabh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for all the effort, @estelle. Great work 🙌

@dipikabh dipikabh merged commit de1b7bb into mdn:main Oct 27, 2023
6 checks passed
@estelle estelle deleted the counterpad branch December 5, 2023 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dipikabh dipikabh dipikabh approved these changes

Assignees

@dipikabh dipikabh

Labels
Content:CSS Cascading Style Sheets docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@estelle @dipikabh