-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove long gone WebExtensions features #30431
Conversation
Preview URLs
External URLs (1)URL: (comment last updated: 2023-12-19 10:58:55) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Elchi3 I think we need some further changes:
- the two deleted images are used to illustrate
tab_background_text
andframe
, so should be renamed rather than deleted (see lines 382 and 760)
-headerURL
is mentioned in lines, 145 to 151. Perhaps change the text to "Optional in desktop Firefox 60 onwards. Required in Firefox for Android." - note referring to
textcolor
on lines 482 to 485 - remove
accentcolor
andtextcolor
from the alias section (from line 1252). We would appear now to only have one alias, forbookmark_text
/toolbar_text
Thanks @rebloor! Will update this PR. Local preview doesn't really work unfortunately due to mdn/yari#4654 |
@Elchi3 poking you regarding updating this PR :) Thank you for your help. |
@zfox23 Thanks for the poke :) I will try to come back to this. It hard to contribute to this page though given mdn/yari#4654. Do you know a workaround? |
@Elchi3 how are you obtaining your preview? I've just checked mine running from |
6c5b87f
to
4ec1b60
Compare
@rebloor Thank you so much! I've made the requested changes. Please take another look. |
@Elchi3, Sorry for the delay in reviewing your update. Everything looks good, and I've merged. Thanks for your help. |
* Remove long gone WebExtensions features * Address review feedback
Description
We consider features irrelevant once they are removed from all browsers for more than two years. This is the case with a few WebExtensions features that this PR proposes to remove from the docs.
Motivation
Cleaning up data and docs, so that readers don't have to read stuff that is not interesting anymore and distracts from other relevant and current information on the page.
Additional details
None.
Related issues and pull requests
BCD companion PR: mdn/browser-compat-data#21305