Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove long gone WebExtensions features #30431

Merged
merged 2 commits into from
Jan 16, 2024
Merged

Conversation

Elchi3
Copy link
Member

@Elchi3 Elchi3 commented Nov 21, 2023

Description

We consider features irrelevant once they are removed from all browsers for more than two years. This is the case with a few WebExtensions features that this PR proposes to remove from the docs.

Motivation

Cleaning up data and docs, so that readers don't have to read stuff that is not interesting anymore and distracts from other relevant and current information on the page.

Additional details

None.

Related issues and pull requests

BCD companion PR: mdn/browser-compat-data#21305

@Elchi3 Elchi3 requested review from a team as code owners November 21, 2023 12:48
@Elchi3 Elchi3 requested review from rebloor and zfox23 and removed request for a team November 21, 2023 12:48
@github-actions github-actions bot added the Content:WebExt WebExtensions docs label Nov 21, 2023
Copy link
Contributor

github-actions bot commented Nov 21, 2023

Copy link
Contributor

@rebloor rebloor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Elchi3 I think we need some further changes:

  • the two deleted images are used to illustrate tab_background_text and frame, so should be renamed rather than deleted (see lines 382 and 760)
    - headerURL is mentioned in lines, 145 to 151. Perhaps change the text to "Optional in desktop Firefox 60 onwards. Required in Firefox for Android."
  • note referring to textcolor on lines 482 to 485
  • remove accentcolor and textcolor from the alias section (from line 1252). We would appear now to only have one alias, for bookmark_text/toolbar_text

@Elchi3
Copy link
Member Author

Elchi3 commented Nov 22, 2023

Thanks @rebloor! Will update this PR. Local preview doesn't really work unfortunately due to mdn/yari#4654

@zfox23
Copy link
Contributor

zfox23 commented Dec 4, 2023

@Elchi3 poking you regarding updating this PR :) Thank you for your help.

@Elchi3
Copy link
Member Author

Elchi3 commented Dec 8, 2023

@zfox23 Thanks for the poke :) I will try to come back to this. It hard to contribute to this page though given mdn/yari#4654. Do you know a workaround?

@rebloor
Copy link
Contributor

rebloor commented Dec 8, 2023

@Elchi3 how are you obtaining your preview? I've just checked mine running from yarn start, which is rendering on port 5042 and doesn't have an issue rendering manifest.json content. Unfortunately, I couldn't explain why this is different from what was happening when I reported mdn/yari#4654.

@Elchi3
Copy link
Member Author

Elchi3 commented Dec 19, 2023

@rebloor Thank you so much!
http://localhost:5042/en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/ works and
http://localhost:3000/en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/ does not!

I've made the requested changes. Please take another look.

@bsmth bsmth requested a review from rebloor January 11, 2024 17:32
@rebloor rebloor merged commit f72ba69 into mdn:main Jan 16, 2024
8 checks passed
@rebloor
Copy link
Contributor

rebloor commented Jan 16, 2024

@Elchi3, Sorry for the delay in reviewing your update. Everything looks good, and I've merged. Thanks for your help.

@Elchi3 Elchi3 deleted the webext-obsolete branch January 16, 2024 09:03
dipikabh pushed a commit to dipikabh/content that referenced this pull request Jan 17, 2024
* Remove long gone WebExtensions features

* Address review feedback
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:WebExt WebExtensions docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants