Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed page reference, section does not exist. #3122

Merged
merged 1 commit into from
May 20, 2021
Merged

Conversation

Alien426
Copy link
Contributor

Checklist — To help your pull request get merged faster, please do the following:

    • Provide a summary of your changes — say what problem you are fixing, what files are changed, and what you've done. This doesn't need to be hugely detailed, as we can see exact changes in the "Files changed" tab.
    • Provide a link to the issue(s) you are fixing, if appropriate, in the form "Fixes url-of-issue". GitHub will render this in the form "Fixes fix: fixable flaws in Glossary A-D entries #1234", with the issue number linked to the issue. Doing this allows us to figure out what issues you are fixing, as well as helping to automate things (for example the issue will be closed once the PR that fixed it has been merged).
    • Review the results of the automated checking we run on every PR and fix any problems reported (see the list of checks near the bottom of the PR page). If you need help, please ask in a comment!
    • Link to any other resources that you think might be useful in reviewing your PR.

@Alien426 Alien426 requested a review from a team as a code owner March 14, 2021 14:15
@Alien426 Alien426 requested review from jpmedley and removed request for a team March 14, 2021 14:15
@hamishwillee
Copy link
Collaborator

The page exists here: https://developer.mozilla.org/en-US/docs/Web/API/Notifications_API

Maybe the Page macro is broken? Could you instead just modify this to something like <a alt="Notification API notes" href="/en-US/docs/Web/API/Notifications_API">Chrome notes</a> ?

@Alien426
Copy link
Contributor Author

The page exists here: https://developer.mozilla.org/en-US/docs/Web/API/Notifications_API
Maybe the Page macro is broken? Could you instead just modify this to something like <a alt="Notification API notes" href="/en-US/docs/Web/API/Notifications_API">Chrome notes</a> ?

The page does exist, but there is no (more) mention of "Chrome" or "incognito" on it. So trying to import/transclude anything from that page makes no sense.

The "Chrome notes" section on "Web/API/Notification/Notification" seems to be say everything relevant as it is.

The history of "Web/API/Notifications_API" does not indicate when "Chrome notes" might have been removed. (I'm pretty new to Github, so maybe I'm missing something.)

Copy link
Collaborator

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 agree that there doesn't seem to be anything useful to include here. Thanks!

@wbamberg wbamberg merged commit a330821 into mdn:main May 20, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants