Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FF122 Relnote CSS -moz-user-focus removed #31970

Merged
merged 3 commits into from
Feb 14, 2024

Conversation

hamishwillee
Copy link
Collaborator

FF122 removes CSS -moz-user-focus for use in content https://bugzilla.mozilla.org/show_bug.cgi?id=1871745 so it can only be used in browser chrome. (and in https://bugzilla.mozilla.org/show_bug.cgi?id=1868552 the default value also changes to normal from none.

Because MDN is for web developers, the fact it can be used in chrome seems irrelevant. I have therefore added a release note in 122 that remove this. Also updated the property page with deprecated (rather than non-standard)

Related docs work can be tracked in #31928

@hamishwillee hamishwillee requested review from a team as code owners January 28, 2024 23:26
@hamishwillee hamishwillee requested review from estelle and pepelsbey and removed request for a team January 28, 2024 23:26
@github-actions github-actions bot added Content:CSS Cascading Style Sheets docs Content:Firefox Content in the Mozilla/Firefox subtree size/m [PR only] 51-500 LoC changed labels Jan 28, 2024
Copy link
Contributor

github-actions bot commented Jan 28, 2024

Preview URLs

External URLs (2)

URL: /en-US/docs/Mozilla/Firefox/Releases/122
Title: Firefox 122 for developers

(comment last updated: 2024-02-13 20:14:14)

@estelle estelle removed their request for review February 1, 2024 23:53
@estelle
Copy link
Member

estelle commented Feb 1, 2024

I removed myself as a reviewer because I don't know this feature.

@hamishwillee
Copy link
Collaborator Author

@pepelsbey Can I please get a review on this?

Copy link
Member

@pepelsbey pepelsbey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I'd suggest pointing developers to an alternative solution to achieve the same goal. There isn't one in CSS, AFAIK, but you can mention tabindex=-1 that also makes elements not focusable.

I'm also not sure whether it makes sense to keep track of features that are supported only in Firefox UI. Let me double-check with the content team.

@github-actions github-actions bot added size/s [PR only] 6-50 LoC changed and removed size/m [PR only] 51-500 LoC changed labels Feb 13, 2024
@hamishwillee
Copy link
Collaborator Author

Thanks @pepelsbey . I've removed the internal stuff. Decided not to add info about tabindex=-1 - if someone chose to use this then it probably wasn't purely for removing focus - i.e. there is no direct replacement.

Copy link
Member

@pepelsbey pepelsbey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you :)

@pepelsbey pepelsbey merged commit 6f56b2d into mdn:main Feb 14, 2024
9 checks passed
@hamishwillee hamishwillee deleted the ff122_moz_user_focus branch February 15, 2024 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:CSS Cascading Style Sheets docs Content:Firefox Content in the Mozilla/Firefox subtree size/s [PR only] 6-50 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants