Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FF115 RTCRtpReceiver.jitterBufferTarget supported #33198

Merged
merged 2 commits into from
May 2, 2024

Conversation

hamishwillee
Copy link
Collaborator

FF115 added support for RTCRtpReceiver.jitterBufferTarget in https://bugzilla.mozilla.org/show_bug.cgi?id=1592988. This was caught by BCD collector and added to BCD in mdn/browser-compat-data#22871

This adds docs for the property and an FF release note update.

@hamishwillee hamishwillee requested review from a team as code owners April 22, 2024 03:13
@hamishwillee hamishwillee requested review from Elchi3 and removed request for a team April 22, 2024 03:13
@github-actions github-actions bot added Content:WebAPI Web API docs Content:Firefox Content in the Mozilla/Firefox subtree labels Apr 22, 2024
The actual user agent jitter buffer target will vary between maximum and minimum allowed values that reflects a target range that the user agent can provide based on network conditions and memory constraints, and can change at any time.
The value returned by `jitterBufferTarget` is not affected by the actual target of the user agent.

The change in average delay can be gradually observed over time by measuring the delta [`RTCInboundRtpStreamStats.jitterBufferDelay`](/en-US/docs/Web/API/RTCInboundRtpStreamStats) divided by the delta [`RTCInboundRtpStreamStats.jitterBufferEmittedCount`](/en-US/docs/Web/API/RTCInboundRtpStreamStats).
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note, these two stats are not documented yet, so I have chosen to link to the parent doc.

Copy link
Contributor

github-actions bot commented Apr 22, 2024

Preview URLs

Flaws (1)

Note! 2 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/API/RTCRtpReceiver/jitterBufferTarget
Title: RTCRtpReceiver: jitterBufferTarget property
Flaw count: 1

  • bad_bcd_queries:
    • No BCD data for query: api.RTCRtpReceiver.jitterBufferTarget
External URLs (1)

URL: /en-US/docs/Mozilla/Firefox/Releases/115
Title: Firefox 115 for developers

(comment last updated: 2024-04-26 01:56:19)

Copy link
Member

@bsmth bsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. One comment for you to look at regarding use of "delta" for calculating average delay (vs. change in average delay?) but leaving a +1 👍🏻

@hamishwillee
Copy link
Collaborator Author

Thanks for the review @bsmth - I modified the part you were concerned about (#33198 (comment)) and I'm happy it addresses your comment, so merging.
But, if you disagree, ping me.

@bsmth
Copy link
Member

bsmth commented May 2, 2024

Thanks for the review @bsmth - I modified the part you were concerned about (#33198 (comment)) and I'm happy it addresses your comment, so merging. But, if you disagree, ping me.

Looks good to me, let's merge 👍🏻

@bsmth bsmth merged commit a9ed680 into mdn:main May 2, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:Firefox Content in the Mozilla/Firefox subtree Content:WebAPI Web API docs size/s [PR only] 6-50 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants