CSS modules: CSS table #33236

estelle · 2024-04-23T13:10:13Z

made the table module follow the newish template guidelines
added links to the module to the five table related properties.

github-actions · 2024-04-23T13:11:21Z

Preview URLs (6 pages)

Flaws (1)

Note! 5 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/CSS/CSS_table
Title: CSS table
Flaw count: 1

broken_links:
- Can't resolve /en-US/docs/Web/CSS/CSS_box_sizing

External URLs (1)

URL: /en-US/docs/Web/CSS/CSS_table
Title: CSS table

https://drafts.csswg.org/css-tables-3/ (1 time) (Note! This may be a new URL 👀)

(comment last updated: 2024-04-25 16:23:59)

dipikabh

Thanks for these updates, @estelle. I’ve suggested some edits and have a few questions for you to consider.

files/en-us/web/css/css_table/index.md

dipikabh · 2024-04-23T22:24:46Z

files/en-us/web/css/css_table/index.md

+  - {{cssxref("border")}} shorthand
+  - {{cssxref("border-width")}}
+  - {{cssxref("border-style")}}
+  - {{cssxref("border-color")}}

 ## Specifications

 {{Specifications}}


I think we should replace the spec-urls front matter key value with "https://drafts.csswg.org/css-tables-3/", the same spec link that you're also using in the note after the Specifications table

See the note below: the spec is not ready for implementation, and has a big orange warning when you visit the page, so opting not to update the spec-url.

It's just that in the Specifications table, we link to "Cascading Style Sheets Level 2 Revision 2 (CSS 2.2) Specification", but in the note we link to "CSS Table Module Level 3 specification". Seems disjointed. I've added a rewording suggestion for the note.

files/en-us/web/css/css_table/index.md

dipikabh · 2024-04-23T22:49:35Z

files/en-us/web/css/css_table/index.md

+  - {{htmlelement("th")}}
+  - {{htmlelement("td")}}
+
+- [CSS box sizing](/en-US/docs/Web/CSS/CSS_box_sizing) module


Suggested change

- [CSS box sizing](/en-US/docs/Web/CSS/CSS_box_sizing) module

- [CSS box model](/en-US/docs/Web/CSS/CSS_box_model) module

The original was correct. See #33182

estelle

Thanks for the review @dipikabh.

I committed most of your changes, and commented on those I did not commit.

estelle · 2024-04-23T23:09:53Z

files/en-us/web/css/css_table/index.md

+  - {{htmlelement("th")}}
+  - {{htmlelement("td")}}
+
+- [CSS box sizing](/en-US/docs/Web/CSS/CSS_box_sizing) module


The original was correct. See #33182

estelle · 2024-04-23T23:11:14Z

files/en-us/web/css/css_table/index.md

+  - {{cssxref("border")}} shorthand
+  - {{cssxref("border-width")}}
+  - {{cssxref("border-style")}}
+  - {{cssxref("border-color")}}

 ## Specifications

 {{Specifications}}


See the note below: the spec is not ready for implementation, and has a big orange warning when you visit the page, so opting not to update the spec-url.

files/en-us/web/css/css_table/index.md

Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>

files/en-us/web/css/css_table/index.md

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

files/en-us/web/css/css_table/index.md

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

files/en-us/web/css/css_table/index.md

dipikabh · 2024-04-25T15:39:58Z

files/en-us/web/css/css_table/index.md

+  - {{cssxref("border")}} shorthand
+  - {{cssxref("border-width")}}
+  - {{cssxref("border-style")}}
+  - {{cssxref("border-color")}}

 ## Specifications

 {{Specifications}}


It's just that in the Specifications table, we link to "Cascading Style Sheets Level 2 Revision 2 (CSS 2.2) Specification", but in the note we link to "CSS Table Module Level 3 specification". Seems disjointed. I've added a rewording suggestion for the note.

dipikabh

Thanks for addressing the comments, @estelle! Leaving a +1 with one suggestion outstanding to possibly reword the "Note".

Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>

CSS modules: CSS table

c14b726

estelle requested a review from a team as a code owner April 23, 2024 13:10

estelle requested review from dipikabh and removed request for a team April 23, 2024 13:10

github-actions bot added Content:CSS Cascading Style Sheets docs size/m [PR only] 51-500 LoC changed labels Apr 23, 2024

CSS modules: CSS table

b007689

dipikabh self-assigned this Apr 23, 2024

dipikabh requested changes Apr 23, 2024

View reviewed changes

estelle commented Apr 23, 2024

View reviewed changes

estelle requested a review from dipikabh April 23, 2024 23:16

estelle and others added 4 commits April 23, 2024 16:17

Apply suggestions from code review

ce3bfaf

Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>

trying again. will it take?

d3278cc

Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>

Merge branch 'main' into table

efaac97

move html down

03fb0fc

github-actions bot reviewed Apr 24, 2024

View reviewed changes

files/en-us/web/css/css_table/index.md Show resolved Hide resolved

estelle and others added 3 commits April 24, 2024 07:45

Merge branch 'main' into table

d18abfe

lint

0785c11

Update files/en-us/web/css/css_table/index.md

3d74910

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

github-actions bot reviewed Apr 24, 2024

View reviewed changes

files/en-us/web/css/css_table/index.md Outdated Show resolved Hide resolved

Update files/en-us/web/css/css_table/index.md

60ac40c

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

dipikabh reviewed Apr 25, 2024

View reviewed changes

dipikabh approved these changes Apr 25, 2024

View reviewed changes

estelle and others added 2 commits April 25, 2024 09:22

Update files/en-us/web/css/css_table/index.md

7401320

Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>

Update files/en-us/web/css/css_table/index.md

4b64ca6

Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>

estelle merged commit b319e19 into mdn:main Apr 25, 2024
8 checks passed

estelle deleted the table branch April 25, 2024 16:23

estelle mentioned this pull request Apr 25, 2024

OWD Project: CSS specs: module landing pages openwebdocs/project#147

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CSS modules: CSS table #33236

CSS modules: CSS table #33236

estelle commented Apr 23, 2024

github-actions bot commented Apr 23, 2024 •

edited

Loading

dipikabh left a comment

dipikabh Apr 23, 2024

estelle Apr 23, 2024

dipikabh Apr 25, 2024

dipikabh Apr 23, 2024

estelle Apr 23, 2024

estelle left a comment

estelle Apr 23, 2024

estelle Apr 23, 2024

dipikabh Apr 25, 2024

dipikabh left a comment

	- [CSS box sizing](/en-US/docs/Web/CSS/CSS_box_sizing) module
	- [CSS box model](/en-US/docs/Web/CSS/CSS_box_model) module

CSS modules: CSS table #33236

CSS modules: CSS table #33236

Conversation

estelle commented Apr 23, 2024

github-actions bot commented Apr 23, 2024 • edited Loading

dipikabh left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

estelle left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dipikabh left a comment

Choose a reason for hiding this comment

github-actions bot commented Apr 23, 2024 •

edited

Loading