Remove reference to setHTML from innerHTML page. #33274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This isn't a useful reference to include on the innerHTML page until the sanitizer API is finished and shipping again.
github-actions
bot
added
Content:WebAPI
|
Preview URLs |
hamishwillee
approved these changes
Apr 26, 2024
There was a problem hiding this comment.
Thanks @lukewarlow - appreciate that you are on top of the use of this API.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This isn't a useful reference to include on the innerHTML page until the sanitizer API is finished and shipping again.
Description
Remove reference to setHTML from innerHTML page.
Motivation
setHTML isn't usable in any current browsers (the brower compat data says Samsung Internet ships it still but thats wrong see mdn/browser-compat-data#22860)
Additional details
This API shipped in Chrome for a few versions before unshipping. However the API is being standardised and will eventually ship, linking to it in it's current state will only lead to user confusion both now and in the future.
Related issues and pull requests
See #33141
See #32731