Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sameSiteCookies option to SharedWorker options #33350

Merged
merged 6 commits into from
May 1, 2024

Conversation

arichiv
Copy link
Contributor

@arichiv arichiv commented May 1, 2024

Description

This is the second of 3 PRs adding spec changes from https://privacycg.github.io/saa-non-cookie-storage/ launching in Chrome 125.

Motivation

sameSiteCookies is a new option for SharedWorker construction that allows a given worker to be restricted to SameSite=None cookies even when created in a first-party context. This is important as only workers without access to SameSite=Lax and SameSite=Strict cookies can be accessed via requestStorageAccess.

Additional details

https://chromestatus.com/feature/5175585823522816

Related issues and pull requests

Relates to mdn/mdn#543

@arichiv arichiv requested a review from a team as a code owner May 1, 2024 13:17
@arichiv arichiv requested review from sideshowbarker and removed request for a team May 1, 2024 13:17
@github-actions github-actions bot added Content:WebAPI Web API docs size/s [PR only] 6-50 LoC changed labels May 1, 2024
@arichiv
Copy link
Contributor Author

arichiv commented May 1, 2024

@sideshowbarker have time to take a look?

Copy link
Contributor

github-actions bot commented May 1, 2024

Preview URLs

(comment last updated: 2024-05-01 14:18:15)

@arichiv
Copy link
Contributor Author

arichiv commented May 1, 2024

@sideshowbarker I noticed the new spec I added shows up as 'unknown' and the older spec that was listed (for SharedWorker) is gone now. Is there a way I could restore the old (default) spec and list the new one alongside it with a name?

@arichiv
Copy link
Contributor Author

arichiv commented May 1, 2024

I'm okay with this as is, how do I follow up to add compat information for sameSiteCookies? It's Chrome 125+ only right now

@sideshowbarker
Copy link
Collaborator

@sideshowbarker I noticed the new spec I added shows up as 'unknown' and the older spec that was listed (for SharedWorker) is gone now. Is there a way I could restore the old (default) spec and list the new one alongside it with a name?

Yes, the way to do that is to edit the file at https://github.com/mdn/browser-compat-data/blob/3bfaadfe0e5f56016ef782c5247f0cfc5a4dfada/api/SharedWorker.json#L67 and change the spec_url value there to an array that includes/adds any additional spec URLs.

@sideshowbarker
Copy link
Collaborator

I'm okay with this as is, how do I follow up to add compat information for sameSiteCookies? It's Chrome 125+ only right now

That’d need to go somewhere in the data at https://github.com/mdn/browser-compat-data/blob/3bfaadfe0e5f56016ef782c5247f0cfc5a4dfada/api/SharedWorker.json#L63

@sideshowbarker sideshowbarker merged commit 37eb7ff into mdn:main May 1, 2024
8 checks passed
@sideshowbarker
Copy link
Collaborator

Ari, let’s go ahead and land this. Any further changes can be handled as follow-up PRs here or in the browser-compat-data repo.

Congrats on landing your first docs change here — welcome aboard 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:WebAPI Web API docs size/s [PR only] 6-50 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants