Normalized Set format and clarified set vs array #3342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was reading the docs on this today and was very confused by how and why the docs were doing things. After spending some time testing the examples, I realized that they simply were not consistent in how they were written and were type casting in someplace for no reason. These changes settle on representing the `Set` according to the standard unless explicitly showing how to convert from a set to an array. This should help devs not already familiar with Set to better understand it and its uniqueness at first glance and reduce confusion like I had by utilizing the standards for Set when applicable
Rumyra
reviewed
Mar 24, 2021
There was a problem hiding this comment.
Thanks so much @RIAEvangelist
Please see the review comments
files/en-us/web/javascript/reference/global_objects/set/index.html
Outdated
Show resolved
Hide resolved
files/en-us/web/javascript/reference/global_objects/set/index.html
Outdated
Show resolved
Hide resolved
files/en-us/web/javascript/reference/global_objects/set/index.html
Outdated
Show resolved
Hide resolved
files/en-us/web/javascript/reference/global_objects/set/index.html
Outdated
Show resolved
Hide resolved
|
Apologies, I had to go to Florida for a funeral. Will review the suggested edits. |
…html Co-authored-by: Ruth John <Rumyra@users.noreply.github.com>
…html Co-authored-by: Ruth John <Rumyra@users.noreply.github.com>
…html Co-authored-by: Ruth John <Rumyra@users.noreply.github.com>
…html added 'Set' to the returns comment for the Set object to increase accuracy. Co-authored-by: Ruth John <Rumyra@users.noreply.github.com>
RIAEvangelist
commented
Mar 31, 2021
|
Thank you so much @RIAEvangelist 🎉 |
Rumyra
approved these changes
Apr 2, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was reading the docs on this today and was very confused by how and why the docs were doing things. After spending some time testing the examples, I realized that they simply were not consistent in how they were written and were type casting in someplace for no reason. These changes settle on representing the
Setaccording to the standard unless explicitly showing how to convert from a set to an array.This should help devs not already familiar with Set to better understand it and its uniqueness at first glance and reduce confusion like I had by utilizing the standards for Set when applicable
Checklist — To help your pull request get merged faster, please do the following: