-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CustomStateSet doc: Add feature detection for :state pseudo-class and browser compatibility warning #33656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Content:WebAPI
Web API docs
size/s
[PR only] 6-50 LoC changed
labels
May 17, 2024
Preview URLs (comment last updated: 2024-05-17 10:01:36) |
minimalsm
commented
May 17, 2024
minimalsm
commented
May 17, 2024
minimalsm
commented
May 17, 2024
minimalsm
commented
May 17, 2024
github-actions
bot
added
size/m
[PR only] 51-500 LoC changed
and removed
size/s
[PR only] 6-50 LoC changed
labels
May 17, 2024
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
minimalsm
changed the title
Update state examples
CustomStateSet doc: Add feature detection for :state pseudo-class and browser compatibility warning
May 17, 2024
sideshowbarker
approved these changes
May 19, 2024
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added feature detection for the :state CSS pseudo-class and provided a warning message if the browser does not support this syntax.
Motivation
The current syntax isn't supported in Chrome browsers yet, and although Chrome 125 is adding support, there will be a transition period where I suspect the majority of readers will be using an incompatible browser.
Additional details
Per @hamishwillee's comment in 33636:
Related issues and pull requests