-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(css): Follow-up PR for shape()
function page
#33783
Conversation
Preview URLs
(comment last updated: 2024-06-14 12:24:47) |
9e7fe6f
to
c608552
Compare
Hi @estelle, @OnkarRuikar, your comments and suggestions are addressed in this PR. PTAL and let me know if these changes look okay to land. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few more nits.
Due to jumps in paths it's not clear where the animations start. To indicate animation progress could you do following change:
@keyframes move {
0% {
offset-distance: 0%;
}
100% {
offset-distance: 100%;
++ background-color: pink;
}
}
Co-authored-by: Onkar Ruikar <87750369+OnkarRuikar@users.noreply.github.com>
Fixed in 8380d65 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Thanks, @OnkarRuikar 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a small suggestion. Otherwise, looks good! Thanks :)
Co-authored-by: Vadim Makeev <hi@pepelsbey.dev>
Thanks a lot for the review, @pepelsbey! |
Description
This is a continuation of #33446 to address the remaining review comments.