Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(css): Follow-up PR for shape() function page #33783

Merged
merged 10 commits into from
Jun 14, 2024

Conversation

dipikabh
Copy link
Contributor

Description

This is a continuation of #33446 to address the remaining review comments.

@github-actions github-actions bot added Content:CSS Cascading Style Sheets docs size/m [PR only] 51-500 LoC changed labels May 28, 2024
Copy link
Contributor

github-actions bot commented May 28, 2024

Preview URLs

(comment last updated: 2024-06-14 12:24:47)

@dipikabh
Copy link
Contributor Author

Hi @estelle, @OnkarRuikar, your comments and suggestions are addressed in this PR. PTAL and let me know if these changes look okay to land. Thanks!

@dipikabh dipikabh marked this pull request as ready for review May 28, 2024 22:55
@dipikabh dipikabh requested a review from a team as a code owner May 28, 2024 22:55
@dipikabh dipikabh requested review from estelle and removed request for a team May 28, 2024 22:55
Copy link
Contributor

@OnkarRuikar OnkarRuikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more nits.
Due to jumps in paths it's not clear where the animations start. To indicate animation progress could you do following change:

@keyframes move {
  0% {
    offset-distance: 0%;
  }
  100% {
    offset-distance: 100%;
++    background-color: pink;
  }
}

files/en-us/web/css/basic-shape/shape/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/basic-shape/shape/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/basic-shape/shape/index.md Outdated Show resolved Hide resolved
dipikabh and others added 2 commits May 30, 2024 11:46
Co-authored-by: Onkar Ruikar <87750369+OnkarRuikar@users.noreply.github.com>
@dipikabh
Copy link
Contributor Author

Due to jumps in paths it's not clear where the animations start.

Fixed in 8380d65

@dipikabh dipikabh requested a review from OnkarRuikar May 30, 2024 16:32
Copy link
Contributor

@OnkarRuikar OnkarRuikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@dipikabh
Copy link
Contributor Author

Thanks, @OnkarRuikar 👍

@estelle estelle requested review from pepelsbey and removed request for estelle June 4, 2024 04:25
Copy link
Member

@pepelsbey pepelsbey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small suggestion. Otherwise, looks good! Thanks :)

files/en-us/web/css/basic-shape/index.md Outdated Show resolved Hide resolved
Co-authored-by: Vadim Makeev <hi@pepelsbey.dev>
@dipikabh
Copy link
Contributor Author

Thanks a lot for the review, @pepelsbey!

@dipikabh dipikabh merged commit acc5072 into mdn:main Jun 14, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:CSS Cascading Style Sheets docs size/m [PR only] 51-500 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants