Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove button class #4088

Merged
merged 2 commits into from
Apr 14, 2021
Merged

Remove button class #4088

merged 2 commits into from
Apr 14, 2021

Conversation

wbamberg
Copy link
Collaborator

As discussed in #3927, this PR changes all occurrences of class="button" into simple links, except for one where the content was not displayed, so I just removed it.

I've also removed the documentation for .button from the CSS style guide.

@wbamberg wbamberg requested review from a team as code owners April 14, 2021 04:48
@wbamberg wbamberg requested review from a team April 14, 2021 04:48
@wbamberg wbamberg requested a review from a team as a code owner April 14, 2021 04:48
@wbamberg wbamberg requested a review from a team April 14, 2021 04:48
@wbamberg wbamberg requested a review from a team as a code owner April 14, 2021 04:48
@wbamberg wbamberg requested review from ericwbailey, Elchi3 and chrisdavidmills and removed request for a team April 14, 2021 04:48
@github-actions
Copy link
Contributor

Preview URLs

Flaws

URL: /en-US/docs/MDN/Guidelines/CSS_style_guide
Title: Guide to classes and styles used in MDN content
on GitHub

No flaws! 🎉


URL: /en-US/docs/Learn
Title: Learn web development
on GitHub
Flaw count: 1

  • broken_links:
    • Can't resolve /en-US/

URL: /en-US/docs/Learn/Tools_and_testing
Title: Tools and testing
on GitHub

No flaws! 🎉


URL: /en-US/docs/Learn/Tools_and_testing/GitHub
Title: Git and GitHub
on GitHub

No flaws! 🎉


URL: /en-US/docs/Learn/Tools_and_testing/Cross_browser_testing
Title: Cross browser testing
on GitHub

No flaws! 🎉


URL: /en-US/docs/Learn/Tools_and_testing/Understanding_client-side_tools
Title: Understanding client-side web development tools
on GitHub

No flaws! 🎉


URL: /en-US/docs/Learn/Tools_and_testing/Client-side_JavaScript_frameworks
Title: Understanding client-side JavaScript frameworks
on GitHub

No flaws! 🎉


URL: /en-US/docs/Learn/HTML
Title: Structuring the web with HTML
on GitHub

No flaws! 🎉


URL: /en-US/docs/Learn/HTML/Introduction_to_HTML
Title: Introduction to HTML
on GitHub

No flaws! 🎉


URL: /en-US/docs/Learn/HTML/Tables
Title: HTML Tables
on GitHub

No flaws! 🎉


URL: /en-US/docs/Learn/HTML/Multimedia_and_embedding
Title: Multimedia and Embedding
on GitHub

No flaws! 🎉


URL: /en-US/docs/Learn/JavaScript
Title: JavaScript — Dynamic client-side scripting
on GitHub

No flaws! 🎉


URL: /en-US/docs/Learn/JavaScript/Client-side_web_APIs
Title: Client-side web APIs
on GitHub

No flaws! 🎉


URL: /en-US/docs/Learn/JavaScript/First_steps
Title: JavaScript First Steps
on GitHub

No flaws! 🎉


URL: /en-US/docs/Learn/JavaScript/Building_blocks
Title: JavaScript building blocks
on GitHub

No flaws! 🎉


URL: /en-US/docs/Learn/JavaScript/Objects
Title: Introducing JavaScript objects
on GitHub

No flaws! 🎉


URL: /en-US/docs/Learn/JavaScript/Asynchronous
Title: Asynchronous JavaScript
on GitHub

No flaws! 🎉


URL: /en-US/docs/Learn/Forms
Title: Web forms — Working with user data
on GitHub

No flaws! 🎉


URL: /en-US/docs/Learn/Accessibility
Title: Accessibility
on GitHub

No flaws! 🎉


URL: /en-US/docs/Learn/CSS
Title: Learn to style HTML using CSS
on GitHub

No flaws! 🎉


URL: /en-US/docs/Learn/CSS/CSS_layout
Title: CSS layout
on GitHub

No flaws! 🎉


URL: /en-US/docs/Learn/CSS/First_steps
Title: CSS first steps
on GitHub

No flaws! 🎉


URL: /en-US/docs/Learn/CSS/Styling_text
Title: Styling text
on GitHub

No flaws! 🎉


URL: /en-US/docs/Learn/CSS/Building_blocks
Title: CSS building blocks
on GitHub

No flaws! 🎉


URL: /en-US/docs/Web/SVG/Applying_SVG_effects_to_HTML_content
Title: Applying SVG effects to HTML content
on GitHub
Flaw count: 2

  • broken_links:
    • Can't resolve /en-US/docs/SVG
    • Can't resolve /en-US/docs/SVG

URL: /en-US/docs/Web/SVG/Namespaces_Crash_Course/Example
Title: Example
on GitHub

No flaws! 🎉


URL: /en-US/docs/Web/API/Web_Audio_API/Using_AudioWorklet
Title: Background audio processing using AudioWorklet
on GitHub
Flaw count: 2

  • macros:
    • /en-US/docs/Web/API/AudioContext/destination redirects to /en-US/docs/Web/API/BaseAudioContext/destination
    • /en-US/docs/Web/API/AudioParamMap/get does not exist

URL: /en-US/docs/Web/HTML
Title: HTML: HyperText Markup Language
on GitHub

No flaws! 🎉


URL: /en-US/docs/Web/JavaScript
Title: JavaScript
on GitHub

No flaws! 🎉


URL: /en-US/docs/Web/CSS
Title: CSS: Cascading Style Sheets
on GitHub

No flaws! 🎉

External URLs

URL: /en-US/docs/MDN/Guidelines/CSS_style_guide
Title: Guide to classes and styles used in MDN content
on GitHub

No external URLs

URL: /en-US/docs/Learn
Title: Learn web development
on GitHub


URL: /en-US/docs/Learn/Tools_and_testing
Title: Tools and testing
on GitHub

No external URLs

URL: /en-US/docs/Learn/Tools_and_testing/GitHub
Title: Git and GitHub
on GitHub


URL: /en-US/docs/Learn/Tools_and_testing/Cross_browser_testing
Title: Cross browser testing
on GitHub

No external URLs

URL: /en-US/docs/Learn/Tools_and_testing/Understanding_client-side_tools
Title: Understanding client-side web development tools
on GitHub

No external URLs

URL: /en-US/docs/Learn/Tools_and_testing/Client-side_JavaScript_frameworks
Title: Understanding client-side JavaScript frameworks
on GitHub


URL: /en-US/docs/Learn/HTML
Title: Structuring the web with HTML
on GitHub

No external URLs

URL: /en-US/docs/Learn/HTML/Introduction_to_HTML
Title: Introduction to HTML
on GitHub


URL: /en-US/docs/Learn/HTML/Tables
Title: HTML Tables
on GitHub


URL: /en-US/docs/Learn/HTML/Multimedia_and_embedding
Title: Multimedia and Embedding
on GitHub


URL: /en-US/docs/Learn/JavaScript
Title: JavaScript — Dynamic client-side scripting
on GitHub


URL: /en-US/docs/Learn/JavaScript/Client-side_web_APIs
Title: Client-side web APIs
on GitHub


URL: /en-US/docs/Learn/JavaScript/First_steps
Title: JavaScript First Steps
on GitHub


URL: /en-US/docs/Learn/JavaScript/Building_blocks
Title: JavaScript building blocks
on GitHub


URL: /en-US/docs/Learn/JavaScript/Objects
Title: Introducing JavaScript objects
on GitHub


URL: /en-US/docs/Learn/JavaScript/Asynchronous
Title: Asynchronous JavaScript
on GitHub


URL: /en-US/docs/Learn/Forms
Title: Web forms — Working with user data
on GitHub


URL: /en-US/docs/Learn/Accessibility
Title: Accessibility
on GitHub


URL: /en-US/docs/Learn/CSS
Title: Learn to style HTML using CSS
on GitHub

No external URLs

URL: /en-US/docs/Learn/CSS/CSS_layout
Title: CSS layout
on GitHub


URL: /en-US/docs/Learn/CSS/First_steps
Title: CSS first steps
on GitHub


URL: /en-US/docs/Learn/CSS/Styling_text
Title: Styling text
on GitHub


URL: /en-US/docs/Learn/CSS/Building_blocks
Title: CSS building blocks
on GitHub


URL: /en-US/docs/Web/SVG/Applying_SVG_effects_to_HTML_content
Title: Applying SVG effects to HTML content
on GitHub


URL: /en-US/docs/Web/SVG/Namespaces_Crash_Course/Example
Title: Example
on GitHub


URL: /en-US/docs/Web/API/Web_Audio_API/Using_AudioWorklet
Title: Background audio processing using AudioWorklet
on GitHub


URL: /en-US/docs/Web/HTML
Title: HTML: HyperText Markup Language
on GitHub

No external URLs

URL: /en-US/docs/Web/JavaScript
Title: JavaScript
on GitHub


URL: /en-US/docs/Web/CSS
Title: CSS: Cascading Style Sheets
on GitHub

Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; thanks @wbamberg !

@chrisdavidmills chrisdavidmills merged commit 2c6f017 into mdn:main Apr 14, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 11, 2022
@wbamberg wbamberg deleted the remove-button-class branch October 15, 2022 17:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants