Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Mozilla/Projects/NSS #4681

Closed
wants to merge 9 commits into from

Conversation

peterbe
Copy link
Contributor

@peterbe peterbe commented May 3, 2021

It's added to the archive here: mdn/archived-content#19

Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chrisdavidmills
Copy link
Contributor

@peterbe hrm, this one has redirect failures on it.

@peterbe
Copy link
Contributor Author

peterbe commented May 4, 2021

I'm really struggling to get the redirects to work. :(
When I add the */docs/Mozilla/Projects/NSS/* lines, it fails the redirects checks. When I run fix-redirects it goes nuts and removes a bunch of weird files.
Either way, I'd rather not do it anyway. It's better to use fundamental redirects for large blocks like this. So I'm going to wait till mdn/yari#3692 lands then merge this PR.

@peterbe
Copy link
Contributor Author

peterbe commented May 6, 2021

@escattone @chrisdavidmills Actually, I think this one is ready to merge.
What will happen is: nothing. Sort'a. We've just moved the content from mdn/content to mdn/archived-content.
Those pages will get a yellow banner saying they're archived.

It's not until we shut down all archived-content use (June 30) that the redirects matter. And for the Mozilla/Projects/NSS that stuff lies with a separate PR just for the redirects.

So if you can sanity check my above logic, I think we can safely merge this.

@hamishwillee
Copy link
Collaborator

Did we consider deleting all this an pointing to the new docs once they exist?

@sideshowbarker
Copy link
Collaborator

@peterbe Not sure who this PR is waiting on action from…

@peterbe
Copy link
Contributor Author

peterbe commented May 26, 2021

@peterbe Not sure who this PR is waiting on action from…

We'll merge this on June 30 2021.

@sideshowbarker
Copy link
Collaborator

We'll merge this on June 30 2021.

@peterbe I notice this has merge conflicts now — which I guess all can be overridden since the files are all being deleted anyway.

But there’s also a conflict in the files/en-us/mozilla/projects/nss file

@Ryuno-Ki
Copy link
Collaborator

@Rumyra Perhaps worth to think about how to track PRs like this that should be merged on a specific date.
(Be it as a personal todo list, a label, a GitHub project or similar)

@peterbe
Copy link
Contributor Author

peterbe commented Aug 18, 2021

Too old now.

@peterbe peterbe closed this Aug 18, 2021
@hamishwillee
Copy link
Collaborator

@peterbe The master plan was to delete this whole tree, which is what this PR did. Whether or not it happens in the PR it still needs to happen. Have you created a replacement PR?

Are you OK if I do? We should let the NSS team know and merge before end of next week.

@peterbe
Copy link
Contributor Author

peterbe commented Aug 20, 2021

Are you OK if I do? We should let the NSS team know and merge before end of next week.

Please do.

@hamishwillee
Copy link
Collaborator

Done #8215

Obviously the redirects issue is not sorted. I am at the point where I'd rather remove this and have broken redirects that have it present.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants