-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Mozilla/Projects/NSS #4681
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@peterbe hrm, this one has redirect failures on it. |
I'm really struggling to get the redirects to work. :( |
@escattone @chrisdavidmills Actually, I think this one is ready to merge. It's not until we shut down all archived-content use (June 30) that the redirects matter. And for the Mozilla/Projects/NSS that stuff lies with a separate PR just for the redirects. So if you can sanity check my above logic, I think we can safely merge this. |
Did we consider deleting all this an pointing to the new docs once they exist? |
@peterbe Not sure who this PR is waiting on action from… |
We'll merge this on June 30 2021. |
@peterbe I notice this has merge conflicts now — which I guess all can be overridden since the files are all being deleted anyway. But there’s also a conflict in the |
@Rumyra Perhaps worth to think about how to track PRs like this that should be merged on a specific date. |
Too old now. |
@peterbe The master plan was to delete this whole tree, which is what this PR did. Whether or not it happens in the PR it still needs to happen. Have you created a replacement PR? Are you OK if I do? We should let the NSS team know and merge before end of next week. |
Please do. |
Done #8215 Obviously the redirects issue is not sorted. I am at the point where I'd rather remove this and have broken redirects that have it present. |
It's added to the archive here: mdn/archived-content#19