Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete URLUtilsReadOnly docs, redirect to WorkerLocation docs #4772

Merged
merged 1 commit into from
May 7, 2021
Merged

Delete URLUtilsReadOnly docs, redirect to WorkerLocation docs #4772

merged 1 commit into from
May 7, 2021

Conversation

sideshowbarker
Copy link
Collaborator

@sideshowbarker sideshowbarker commented May 6, 2021 •
edited
Loading

whatwg/html@32a7a20 completely removed the URLUtilsReadOnly interface and moved/inlined/hoisted its members up into the WorkerLocation interface. So this change deletes all the URLUtilsReadOnly docs, and redirects them to the WorkerLocation docs.

Related BCD change: mdn/browser-compat-data#10347

@sideshowbarker sideshowbarker requested review from a team as code owners May 6, 2021 22:43
@sideshowbarker sideshowbarker requested review from chrisdavidmills and removed request for a team May 6, 2021 22:43
@github-actions
Copy link
Contributor

github-actions bot commented May 6, 2021 •
edited
Loading

Preview URLs

Flaws

Note! 1 document with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/API/WorkerLocation/pathname
Title: WorkerLocation.pathname
on GitHub
Flaw count: 1

  • bad_bcd_queries:
    • No BCD data for query: api.WorkerLocation.pathname

URL: /en-US/docs/Web/API/WorkerLocation/hash
Title: WorkerLocation.hash
on GitHub
Flaw count: 1

  • bad_bcd_queries:
    • No BCD data for query: api.WorkerLocation.hash

URL: /en-US/docs/Web/API/WorkerLocation/search
Title: WorkerLocation.search
on GitHub
Flaw count: 1

  • bad_bcd_queries:
    • No BCD data for query: api.WorkerLocation.search

URL: /en-US/docs/Web/API/WorkerLocation/host
Title: WorkerLocation.host
on GitHub
Flaw count: 1

  • bad_bcd_queries:
    • No BCD data for query: api.WorkerLocation.host

URL: /en-US/docs/Web/API/WorkerLocation/port
Title: WorkerLocation.port
on GitHub
Flaw count: 1

  • bad_bcd_queries:
    • No BCD data for query: api.WorkerLocation.port

URL: /en-US/docs/Web/API/WorkerLocation/protocol
Title: WorkerLocation.protocol
on GitHub
Flaw count: 1

  • bad_bcd_queries:
    • No BCD data for query: api.WorkerLocation.protocol

URL: /en-US/docs/Web/API/WorkerLocation/origin
Title: WorkerLocation.origin
on GitHub
Flaw count: 1

  • bad_bcd_queries:
    • No BCD data for query: api.WorkerLocation.origin

URL: /en-US/docs/Web/API/WorkerLocation/hostname
Title: WorkerLocation.hostname
on GitHub
Flaw count: 1

  • bad_bcd_queries:
    • No BCD data for query: api.WorkerLocation.hostname

URL: /en-US/docs/Web/API/WorkerLocation/toString
Title: WorkerLocation.toString()
on GitHub
Flaw count: 1

  • bad_bcd_queries:
    • No BCD data for query: api.WorkerLocation.toString

URL: /en-US/docs/Web/API/WorkerLocation/href
Title: WorkerLocation.href
on GitHub
Flaw count: 1

  • bad_bcd_queries:
    • No BCD data for query: api.WorkerLocation.href

URL: /en-US/docs/Web/API/URL_API
Title: URL API
on GitHub
Flaw count: 1

  • macros:
    • /en-US/docs/Web/CSS/url redirects to /en-US/docs/Web/CSS/url()

External URLs

URL: /en-US/docs/Web/API/WorkerLocation
Title: WorkerLocation
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/WorkerLocation/pathname
Title: WorkerLocation.pathname
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/WorkerLocation/hash
Title: WorkerLocation.hash
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/WorkerLocation/search
Title: WorkerLocation.search
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/WorkerLocation/host
Title: WorkerLocation.host
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/WorkerLocation/port
Title: WorkerLocation.port
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/WorkerLocation/protocol
Title: WorkerLocation.protocol
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/WorkerLocation/origin
Title: WorkerLocation.origin
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/WorkerLocation/hostname
Title: WorkerLocation.hostname
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/WorkerLocation/toString
Title: WorkerLocation.toString()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/WorkerLocation/href
Title: WorkerLocation.href
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/URL_API
Title: URL API
on GitHub

(this comment was updated 2021-05-07 05:04:36.072317)

@sideshowbarker sideshowbarker marked this pull request as draft May 7, 2021 01:29
wbamberg
wbamberg reviewed May 7, 2021
View reviewed changes
Copy link
Collaborator

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine, although I had a question about one sentence that didn't seem very useful any more.

But it looks like all the redirects work, and the redirect entries match the removed files.

files/en-us/web/api/url_api/index.html Outdated Show resolved Hide resolved
@sideshowbarker sideshowbarker marked this pull request as ready for review May 7, 2021 04:28
@sideshowbarker sideshowbarker force-pushed the sideshowbarker/URLUtilsReadOnly-move branch from 7b34220 to 646b988 Compare May 7, 2021 04:31
@sideshowbarker sideshowbarker changed the title Delete URLUtilsReadOnly docs, redirect to URL docs Delete URLUtilsReadOnly docs, redirect to WorkerLocation docs May 7, 2021
@sideshowbarker sideshowbarker force-pushed the sideshowbarker/URLUtilsReadOnly-move branch from 646b988 to fe68d32 Compare May 7, 2021 04:34
sideshowbarker added a commit to w3c/browser-compat-data that referenced this pull request May 7, 2021
@sideshowbarker
Delete URLUtilsReadOnly, move members to WorkerLocation
ae4c92d 
whatwg/html@32a7a20 completely removed the
URLUtilsReadOnly interface and moved/inlined/hoisted its members up
into the WorkerLocation interface. So this change deletes
URLUtilsReadOnly, and moves its members to WorkerLocation.

This change also adds spec URLs to the WorkerLocation data.

Related MDN change: mdn/content#4772
@sideshowbarker sideshowbarker mentioned this pull request May 7, 2021
Merged
@sideshowbarker
Delete URLUtilsReadOnly docs, redirect to WorkerLocation docs
5c788dd 
whatwg/html@32a7a20 completely removed the
URLUtilsReadOnly interface and moved/inlined/hoisted its members up
into the WorkerLocation interface. So this change deletes all the
URLUtilsReadOnly docs, and redirects them to the WorkerLocation docs.

Related BCD change: mdn/browser-compat-data#10347
@sideshowbarker sideshowbarker force-pushed the sideshowbarker/URLUtilsReadOnly-move branch from fe68d32 to 5c788dd Compare May 7, 2021 05:02
@sideshowbarker sideshowbarker mentioned this pull request May 7, 2021
Merged
chrisdavidmills
chrisdavidmills approved these changes May 7, 2021
View reviewed changes
Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like @sideshowbarker 's latest changes satisfied @wbamberg 's query, so I think I'll go ahead and merge this. Thanks Mike!

@chrisdavidmills chrisdavidmills merged commit 5e27ba0 into main May 7, 2021
@chrisdavidmills chrisdavidmills deleted the sideshowbarker/URLUtilsReadOnly-move branch May 7, 2021 07:15
Elchi3 added a commit to mdn/browser-compat-data that referenced this pull request May 7, 2021
@sideshowbarker @Elchi3
Delete URLUtilsReadOnly, move members to WorkerLocation (#10347)
7a27055 
* Delete URLUtilsReadOnly, move members to WorkerLocation

whatwg/html@32a7a20 completely removed the
URLUtilsReadOnly interface and moved/inlined/hoisted its members up
into the WorkerLocation interface. So this change deletes
URLUtilsReadOnly, and moves its members to WorkerLocation.

This change also adds spec URLs to the WorkerLocation data.

Related MDN change: mdn/content#4772

* Apply suggestions from code review

Co-authored-by: Florian Scholz <fs@florianscholz.com>

Co-authored-by: Florian Scholz <fs@florianscholz.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chrisdavidmills chrisdavidmills chrisdavidmills approved these changes

@wbamberg wbamberg Awaiting requested review from wbamberg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sideshowbarker @chrisdavidmills @wbamberg