Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SVGStylable - deprecated or not? #4782

Closed
wants to merge 2 commits into from

Conversation

hamishwillee
Copy link
Collaborator

https://developer.mozilla.org/en-US/docs/Web/API/SVGStylable

This is marked as deprecated on MDN but not in BCD. I did a search and found SVGStylable.getPresentationAttribute() is deprecated - see https://www.w3.org/Graphics/SVG/WG/track/actions/2696 and the spec https://www.w3.org/TR/SVG11/types.html#InterfaceSVGStylable - but not whole of SVGStylable.

So what this does is remove the top level deprecation macro and add the inline deprecation for SVGStylable.getPresentationAttribute()

While here I added the bcd compatibility tag/macro, and tidied up the methods section to match MDN standards.

Before I go update BCD, any suggestions on how I can confirm this?

@hamishwillee hamishwillee requested a review from a team as a code owner May 7, 2021 06:25
@hamishwillee hamishwillee requested review from Rumyra and removed request for a team May 7, 2021 06:25
@github-actions
Copy link
Contributor

github-actions bot commented May 7, 2021

Preview URLs

Flaws

URL: /en-US/docs/Web/API/SVGStylable
Title: SVGStylable
on GitHub
Flaw count: 1

  • macros:
    • /en-US/docs/Web/API/SVGStylable/getPresentationAttribute does not exist

External URLs

URL: /en-US/docs/Web/API/SVGStylable
Title: SVGStylable
on GitHub

No new external URLs

@Rumyra
Copy link
Collaborator

Rumyra commented May 18, 2021

From what I can gather the whole SVGStylable interface was removed with SVG v2 https://www.w3.org/TR/SVG2/changes.html#types

I assume that's what the original depreciated notice was all about - however I'm unsure how this is represented in bcd...

@hamishwillee
Copy link
Collaborator Author

Thanks @Rumyra . Well, since we posted this it got removed, and I see that this is now a redirect - so you or someone else fixed this. Closing :-)

FYI only the BCD issue associated with this: mdn/browser-compat-data#10536

@hamishwillee hamishwillee deleted the svg_stylable branch May 21, 2021 04:07
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants