Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete SVGTransformable as was never implemented #5045

Merged
merged 2 commits into from
May 17, 2021

Conversation

hamishwillee
Copy link
Collaborator

Delete SVGTransformable and break links to it.

Discussion with Daniel Beck here indicates that this interface was never implemented before the spec changed it to something else. In BCD this was/will be deleted.

This change on MDN deletes the associated MDN entry. Further, the item was linked from a number of places where there is a statement about the spec change. In those cases I have kept the information about the change, but made the link into code. Upshot is that the trail of change is still trackable, but the irrelevant info about the unimplemented interface is gone.

@hamishwillee hamishwillee requested review from a team as code owners May 17, 2021 04:07
@hamishwillee hamishwillee requested review from chrisdavidmills and removed request for a team May 17, 2021 04:07
@github-actions
Copy link
Contributor

Preview URLs

Flaws

URL: /en-US/docs/Mozilla/Firefox/Releases/3.6/Interfaces_moved
Title: Interfaces moved in Firefox 3.6
on GitHub
Flaw count: 351

  • macros:
    • /en-US/docs/Mozilla/Tech/XPCOM/Reference/Interface/nsIBrowserDOMWindow does not exist
    • /en-US/docs/Mozilla/Tech/XPCOM/Reference/Interface/nsIDOMBarProp does not exist
    • /en-US/docs/Mozilla/Tech/XPCOM/Reference/Interface/nsIDOMCRMFObject does not exist
    • /en-US/docs/Mozilla/Tech/XPCOM/Reference/Interface/nsIDOMChromeWindow does not exist
    • /en-US/docs/Mozilla/Tech/XPCOM/Reference/Interface/nsIDOMClientInformation does not exist
    • and 346 more flaws omitted

URL: /en-US/docs/Web/API/Document_Object_Model
Title: Document Object Model (DOM)
on GitHub
Flaw count: 60

  • macros:
    • /en-US/docs/Web/API/DOMConfiguration does not exist
    • /en-US/docs/Web/API/DOMErrorHandler does not exist
    • /en-US/docs/Web/API/DOMImplementationList does not exist
    • /en-US/docs/Web/API/DOMImplementationRegistry does not exist
    • /en-US/docs/Web/API/DOMImplementationSource does not exist
    • and 55 more flaws omitted

URL: /en-US/docs/Web/API/SVGCircleElement
Title: SVGCircleElement
on GitHub
Flaw count: 1

  • macros:
    • /en-US/docs/Web/API/SVGLangSpace does not exist

URL: /en-US/docs/Web/API/SVGClipPathElement
Title: SVGClipPathElement
on GitHub
Flaw count: 2

  • macros:
    • /en-US/docs/Web/API/SVGClipPathElement/clipPathUnits does not exist
    • /en-US/docs/Web/API/SVGLangSpace does not exist

URL: /en-US/docs/Web/API/SVGDefsElement
Title: SVGDefsElement
on GitHub
Flaw count: 1

  • macros:
    • /en-US/docs/Web/API/SVGLangSpace does not exist

URL: /en-US/docs/Web/API/SVGAElement
Title: SVGAElement
on GitHub
Flaw count: 12

  • macros:
    • /en-US/docs/Web/API/HTMLHyperlinkElementUtils does not exist
    • /en-US/docs/Web/API/SVGAElement/download does not exist
    • /en-US/docs/Web/API/SVGAElement/href does not exist
    • /en-US/docs/Web/API/SVGAElement/hreflang does not exist
    • /en-US/docs/Web/API/SVGAElement/ping does not exist
    • and 7 more flaws omitted

External URLs

URL: /en-US/docs/Mozilla/Firefox/Releases/3.6/Interfaces_moved
Title: Interfaces moved in Firefox 3.6
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/Document_Object_Model
Title: Document Object Model (DOM)
on GitHub


URL: /en-US/docs/Web/API/SVGCircleElement
Title: SVGCircleElement
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/SVGClipPathElement
Title: SVGClipPathElement
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/SVGDefsElement
Title: SVGDefsElement
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/SVGAElement
Title: SVGAElement
on GitHub

No new external URLs

Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; thanks @hamishwillee !

@chrisdavidmills chrisdavidmills merged commit a8020f2 into mdn:main May 17, 2021
@hamishwillee hamishwillee deleted the svgtransformable branch May 17, 2021 23:57
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants