Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note about PaintWorklet privacy leak #6259

Merged
merged 3 commits into from
Jun 23, 2021

Conversation

sideshowbarker
Copy link
Collaborator

Fixes #6257

@sideshowbarker
Copy link
Collaborator Author

@Kaiido — If you can confirm whether Firefox and/or Safari do the same thing here, we can update the patch to mention them along with Chrome.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 23, 2021

Preview URLs

Flaws

None! 🎉

External URLs

URL: /en-US/docs/Web/API/PaintWorklet
Title: PaintWorklet
on GitHub

(this comment was updated 2021-06-23 13:26:10.212918)

@Kaiido
Copy link
Contributor

Kaiido commented Jun 23, 2021

@Kaiido — If you can confirm whether Firefox and/or Safari do the same thing here, we can update the patch to mention them along with Chrome.

I believe only Chromium based browsers expose this API currently, so others UAs behavior is undefined here.

@sideshowbarker
Copy link
Collaborator Author

I believe only Chromium based browsers expose this API currently

ah yes — thanks, yeah, I see that’s what the https://developer.mozilla.org/en-US/docs/Web/API/PaintWorklet#browser_compatibility table shows

@Elchi3
Copy link
Member

Elchi3 commented Jun 23, 2021

Do we want to put this in a section with the heading "Privacy concerns"? Other MDN pages use "Accessibility concerns" or "Performance concerns" for similar remarks.

@sideshowbarker
Copy link
Collaborator Author

Do we want to put this in a section with the heading "Privacy concerns"? Other MDN pages use "Accessibility concerns" or "Performance concerns" for similar remarks.

Good point — yep, added

Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, well done! 👍

@Elchi3 Elchi3 merged commit a5ea899 into main Jun 23, 2021
@Elchi3 Elchi3 deleted the sideshowbarker/paintworklet-privacy-leak-note branch June 23, 2021 13:33
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 2, 2022
Jolly608090 referenced this pull request in github/docs Aug 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with "PaintWorklet": Add note that this feature is disabled for elements inside <a href>
3 participants