Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Markdown][MathML] Prepare MathML for Markdowning #9685

Merged
merged 2 commits into from
Oct 9, 2021

Conversation

wbamberg
Copy link
Collaborator

@wbamberg wbamberg commented Oct 9, 2021

This PR prepares the MathML docs (https://developer.mozilla.org/en-US/docs/Web/MathML) for Markdowning.

After this PR the only unconverted element is the table in https://developer.mozilla.org/en-US/docs/Web/MathML/Attribute which should stay in HTML because it will be too wide in GFM.

Technically I ought to convert all the examples, like this one:

<p>Your browser rendering: <math> <mfrac bevelled="true"> <mfrac> <mi> a </mi> <mi> b </mi> </mfrac> <mfrac> <mi> c </mi> <mi> d </mi> </mfrac> </mfrac> </math></p>

...to be live samples, but it doesn't really seem worth it.

@wbamberg wbamberg requested a review from a team as a code owner October 9, 2021 00:15
@wbamberg wbamberg requested review from sideshowbarker and removed request for a team October 9, 2021 00:15
@github-actions github-actions bot added the Content:MathML MathML docs label Oct 9, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2021

Preview URLs

Flaws

Note! 17 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/MathML/Fonts
Title: Fonts for Mozilla's MathML engine
on GitHub
Flaw count: 4

  • broken_links:
    • Anchor not lowercase
    • Anchor not lowercase
  • bad_pre_tags:
    • <pre><code>CODE can be just <pre>CODE
    • <pre><code>CODE can be just <pre>CODE

URL: /en-US/docs/Web/MathML/Authoring
Title: Authoring MathML
on GitHub
Flaw count: 3

  • broken_links:
    • Can't resolve /en-US/docs/Mozilla/MathML_Project#Sample_MathML_Documents
    • Can't resolve /en-US/docs/Mozilla/MathML_Project/Fonts
    • Can't resolve /en-US/docs/Mozilla/MathML_Project/FontsMozilla2.0#MathML_Font_Selection_with_CSS

URL: /en-US/docs/Web/MathML/Element/mmultiscripts
Title: <mmultiscripts>
on GitHub
Flaw count: 1

  • broken_links:
    • Can't resolve /en-US/docs/Error_Console

External URLs

URL: /en-US/docs/Web/MathML
Title: MathML
on GitHub

No new external URLs


URL: /en-US/docs/Web/MathML/Fonts
Title: Fonts for Mozilla's MathML engine
on GitHub


URL: /en-US/docs/Web/MathML/Fonts/Test
Title: Test
on GitHub

No new external URLs


URL: /en-US/docs/Web/MathML/Authoring
Title: Authoring MathML
on GitHub


URL: /en-US/docs/Web/MathML/Attribute
Title: MathML attribute reference
on GitHub

No new external URLs


URL: /en-US/docs/Web/MathML/Attribute/Values
Title: Values
on GitHub


URL: /en-US/docs/Web/MathML/Element
Title: MathML element reference
on GitHub


URL: /en-US/docs/Web/MathML/Element/mmultiscripts
Title: <mmultiscripts>
on GitHub

No new external URLs


URL: /en-US/docs/Web/MathML/Element/msubsup
Title: <msubsup>
on GitHub

No new external URLs


URL: /en-US/docs/Web/MathML/Element/msup
Title: <msup>
on GitHub

No new external URLs


URL: /en-US/docs/Web/MathML/Element/mover
Title: <mover>
on GitHub

No new external URLs


URL: /en-US/docs/Web/MathML/Element/mtable
Title: <mtable>
on GitHub

No new external URLs


URL: /en-US/docs/Web/MathML/Element/mfrac
Title: <mfrac>
on GitHub

No new external URLs


URL: /en-US/docs/Web/MathML/Element/munder
Title: <munder>
on GitHub

No new external URLs


URL: /en-US/docs/Web/MathML/Element/munderover
Title: <munderover>
on GitHub

No new external URLs


URL: /en-US/docs/Web/MathML/Element/msqrt
Title: <msqrt>
on GitHub

No new external URLs


URL: /en-US/docs/Web/MathML/Element/msub
Title: <msub>
on GitHub

No new external URLs


URL: /en-US/docs/Web/MathML/Element/mroot
Title: <mroot>
on GitHub

No new external URLs


URL: /en-US/docs/Web/MathML/Element/mphantom
Title: <mphantom>
on GitHub

No new external URLs


URL: /en-US/docs/Web/MathML/Examples/MathML_Pythagorean_Theorem
Title: Proving the Pythagorean theorem
on GitHub

No new external URLs

Copy link
Contributor

@teoli2003 teoli2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me. And you are right there is no point in doing more than the conversion here for the moment.

@teoli2003 teoli2003 merged commit 0b0b0a6 into mdn:main Oct 9, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 9, 2022
@wbamberg wbamberg deleted the prepare-mathml branch October 15, 2022 17:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Content:MathML MathML docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants