Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(css): Fix/Add synatx for font-palette <palette-identifier> palette-mix() #785

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

skyclouds2001
Copy link
Contributor

@skyclouds2001 skyclouds2001 commented Nov 18, 2024

Description

see #675

add missing syntax for <palette-identifier>, see https://drafts.csswg.org/css-fonts/#typedef-font-palette-palette-identifier

add mdn_url for font-palette

update synatx of font-palette to support new palette-mix() usage, which is supported since chromium M121 per BCD
and change animation type to by computed value, which happens since chromium M121 per BCD

add missing data for palette-mix()

Motivation

Additional details

Related issues and pull requests

Fixes #675

Reported in #597

/cc @lahmatiy

@skyclouds2001 skyclouds2001 marked this pull request as ready for review November 18, 2024 19:52
@skyclouds2001 skyclouds2001 requested a review from a team as a code owner November 18, 2024 19:52
@skyclouds2001 skyclouds2001 requested review from pepelsbey and removed request for a team November 18, 2024 19:52
@skyclouds2001 skyclouds2001 changed the title feat(css): Add missing syntax for <palette-identifier> feat(css): Fix/Add synatx for font-palette <palette-identifier> palette-mix() Nov 19, 2024
Copy link
Member

@bsmth bsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

palette-identifier doesn't have a definition
2 participants