Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS editor should not focus on page load #1148

Closed
wbamberg opened this issue Sep 19, 2018 · 2 comments
Closed

CSS editor should not focus on page load #1148

wbamberg opened this issue Sep 19, 2018 · 2 comments

Comments

@wbamberg
Copy link
Contributor

The CSS editor focuses when the page loads. This breaks links to fragments: https://developer.mozilla.org/en-US/docs/Web/CSS/margin#Specifications.

The idea here was to emphasise that the examples were editable, but I'm not sure this is effective, and I don't think it is worth the cost.

I think it's not quite as simple as removing https://github.com/mdn/interactive-examples/blob/master/js/editor-libs/css-editor-utils.js#L40 - doing only that means the user has to click twice in a box before getting the focus.

@stephaniehobson
Copy link
Contributor

The first item still inits so it's one click to edit not two. I think this is a good improvement. You could keep an eye on the editor stats for the first couple weeks after this is launched if you're worried.

schalkneethling pushed a commit that referenced this issue Sep 24, 2018
#1148

The first item still auto selects/inits so it's only one click to put the cursor in not two.
@wbamberg
Copy link
Contributor Author

Fixed -> #1158 - thanks @stephaniehobson !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants