Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed .output rules from tabbed examples #2201

Merged
merged 2 commits into from
Aug 31, 2022
Merged

Conversation

NiedziolkaMichal
Copy link
Member

This PR removes all rules in tabbed(html) examples refering to class "output". This class is used by HTML element living outside of the example and which is wrapping whole example output content. It is not shown in HTML tab, therefore it can be found only by using dev tools. I believe it might be confusing to the users, as they might be searching for this element and they will not be able to find it.

Elements embed, iframe, object, picture & source are setting #eee background color by using .output. Removing those rules doesn't have any visual impact, as #eee is very close to #fff used in other examples.

Element select is setting background image. Removing this rule makes this example look similar to option example and fixes #2171

Element wbr is setting background color to grey. This has significant impact, as edges of the inner white element can be easily seen. I have removed grey background and created dashed border instead, just like in CSS example line-break.

Other examples are just changing font family by declaration "font: 1rem 'Fira Sans', sans-serif;". Removing this has very low impact and makes font family uniform with other examples. In global attribute tabindex and contenteditable I had to set font-weight to bold, to keep previews style.

Examples accesskey, dir, enterkeyhint, spellcheck, style don't have any content in CSS tab now. If that's a problem I can add something to them or if #812 gets passed, we could remove css tab from those examples.

@NiedziolkaMichal
Copy link
Member Author

I also removed hamser image, which is no longer used by any example.

@wbamberg
Copy link
Contributor

I also removed hamser image, which is no longer used by any example.

😭 well I'm going to miss the little guy, but it's about time he went I suppose.

Copy link
Contributor

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 nice change @NiedziolkaMichal .

@wbamberg wbamberg merged commit d82f61a into mdn:main Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

<select> example not working
2 participants