Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(CSS): add :host, :host-context, and ::slotted selector examples #2560

Merged
merged 5 commits into from
Jul 21, 2023

Conversation

OnkarRuikar
Copy link
Contributor

To test checkout the branch in local then run

npm install
npm run build
npm start

Open following URLs in browser:

http://localhost:9090/pages/tabbed/pseudo-class-host.html
http://localhost:9090/pages/tabbed/pseudo-class-host_function.html
http://localhost:9090/pages/tabbed/pseudo-class-host-context.html
http://localhost:9090/pages/tabbed/pseudo-element-slotted.html

@Rumyra Rumyra merged commit 72cc86c into mdn:main Jul 21, 2023
@Rumyra
Copy link
Contributor

Rumyra commented Jul 21, 2023

Thanks @OnkarRuikar - these look great :D

@OnkarRuikar OnkarRuikar deleted the host_selectors branch July 22, 2023 01:04
@NiedziolkaMichal
Copy link
Member

Too bad I created similar examples more than a year ago and they were never reviewed: #2177 #2186
I will close those PRs.

@OnkarRuikar
Copy link
Contributor Author

Too bad I created similar examples more than a year ago and they were never reviewed: #2177 #2186 I will close those PRs.

😰 I should've looked for existing PRs first. Never though something that old would already exist.

@sideshowbarker
Copy link
Member

Too bad I created similar examples more than a year ago and they were never reviewed: #2177 #2186
I will close those PRs.

Please don't close them. I have been reviewing and merging the open PRs here, and I plan to get all of them merged soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants