Skip to content
This repository has been archived by the owner on Aug 26, 2022. It is now read-only.

Update minor Node version in kuma_base Docker image #6214

Closed
callahad opened this issue Dec 6, 2019 · 2 comments · Fixed by #6222
Closed

Update minor Node version in kuma_base Docker image #6214

callahad opened this issue Dec 6, 2019 · 2 comments · Fixed by #6222
Labels
status: needs triage Status: Untriaged

Comments

@callahad
Copy link
Contributor

callahad commented Dec 6, 2019

Our kuma_base image currently pulls in Node 10.16.3:

kuma/docker/images/kuma_base/Dockerfile

Line 4 in 6d51409

ENV NODE_VERSION=10.16.3 \

Node 10.17.0 was released two months ago; we should bump the version.

Note: Node v10 is an LTS release that is supported until April 2021, so no urgent changes needed, but it enters "Maintenance LTS" in April 2020, so we'll want to move to Node v12 some time next year.
@callahad callahad added the status: needs triage Status: Untriaged label Dec 6, 2019
@callahad
Copy link
Contributor Author

callahad commented Dec 6, 2019

If nothing else, this would at least give us a better error message for #6195 😁

@peterbe
Copy link
Contributor

peterbe commented Dec 9, 2019

Do we have any objections to just going for Node 12 here?

peterbe added a commit to peterbe/kuma that referenced this issue Dec 9, 2019
@peterbe
Node 12 in Kuma
f6fa2bf 
Fixes mdn#6214
@peterbe peterbe mentioned this issue Dec 9, 2019
Merged
peterbe added a commit that referenced this issue Dec 9, 2019
@peterbe
Node 12 in Kuma (#6222)
7128e3b 
Fixes #6214
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
status: needs triage Status: Untriaged
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Node 12 in Kuma peterbe/kuma
2 participants
@callahad @peterbe