This repository has been archived by the owner on Aug 26, 2022. It is now read-only.
Bug 747403 -- refine section ID generation #283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a first step, namely matching MindTouch behavior for sections whose names contain non-ASCII characters. We now generate IDs in a similar way: any section name which contains only ASCII content merely has spaces replaced with underscores. A name which contains non-ASCII characters has each such character replaced by hexadecimal digits representing the appropriate UTF-8 codepoint(s), with each set of digits preceded by a dot. The test cases are a sampling of non-ASCII and mixed-character-set section names and the slugs MindTouch generates for them. This does not guarantee absolute parity with MindTouch, but probably gets us close enough. It also does not deal with the problem of a document in which not all section names are unique, but so far as I can tell this does not introduce any new problems, merely perpeturts an old one, assuming any such documents exist.
|
Taking a peek. |
|
Tests pass, and the anchors match the handful of french locale pages I checked between my laptop Kuma and prod MindTouch. r+ |
lmorchard
added a commit
that referenced
this pull request
Jun 19, 2012
Bug 747403 -- refine section ID generation
stephaniehobson
added a commit
that referenced
this pull request
Oct 19, 2017
…mance-prefetch-preconnect Fix issue #283, add dns-prefetch, preconnect for editor iframe
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first step, namely matching MindTouch behavior for sections
whose names contain non-ASCII characters. We now generate IDs in a
similar way: any section name which contains only ASCII content merely
has spaces replaced with underscores. A name which contains non-ASCII
characters has each such character replaced by hexadecimal digits
representing the appropriate UTF-8 codepoint(s), with each set of
digits preceded by a dot.
The test cases are a sampling of non-ASCII and mixed-character-set
section names and the slugs MindTouch generates for them.
This does not guarantee absolute parity with MindTouch, but probably
gets us close enough. It also does not deal with the problem of a
document in which not all section names are unique, but so far as I
can tell this does not introduce any new problems, merely perpeturts
an old one, assuming any such documents exist.