Skip to content
This repository has been archived by the owner on Jun 21, 2022. It is now read-only.

add initial config for renovate #1251

Merged
merged 2 commits into from
Oct 4, 2019
Merged

add initial config for renovate #1251

merged 2 commits into from
Oct 4, 2019

Conversation

escattone
Copy link
Contributor

@escattone escattone commented Oct 4, 2019

Proposed initial config for renovate. renovate is not yet enabled for this repo, but I'd like to enable it once #1249 lands in order to pin the digests in the Dockerfile. This config also exposes package.json to renovate, but we might not want to do that yet.

@escattone escattone requested a review from peterbe October 4, 2019 17:49
Copy link
Contributor

@peterbe peterbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm... Are we ready for the onslaught of Renovate PRs to update dependencies in package.json? With Kuma we did:

"ignorePaths": [
    "package.json",

Also, Kumascript uses the old legacy npm-shrinkwrap.json solution which I don't even know if Renovate supports.

As I vaguely understood it, npm-shrinkwrap.json was the old way and package-lock.json is the hit new thing.

@escattone
Copy link
Contributor Author

@peterbe Good points! I don't think we're ready yet for the onslaught of Renovate PRs to update dependencies in package.json, and like you said, we'd probably have to upgrade to using package-lock.json anyway, so I'll add the "ignorePaths": ["package.json"] here, and we'll just focus on pinning the digest in the Dockerfile.

@peterbe
Copy link
Contributor

peterbe commented Oct 4, 2019

If it doesn't work, we can tune it later.

@escattone escattone merged commit 552e7e5 into mdn:master Oct 4, 2019
@escattone escattone deleted the add-renovate-config branch October 4, 2019 21:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants