feat: translate window/scrollby in ko #10976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview URLs Flaws (3)URL:
|
hochan222
approved these changes
Jan 18, 2023
| \- 혹은 - | ||
|
|
||
| - `options` | ||
| - : 다음 매개변수가 포함된 사전. |
There was a problem hiding this comment.
Suggested change
| - : 다음 매개변수가 포함된 사전. | |
| - : 다음 매개변수가 포함된 사전. |
A dictionary containing the following parameters:
영어 원문일때는 괜찮아 보였는데 번역이 사전이 되어버리니까.. 뭔가 의미전달이 잘 안되는것같기도 하네요.. 키값을 갖는 객체.. 음.. 오랜시간 고민했지만 결국 사전으로 두는게 좋아보입니다.
명세에 정의가 dictionary로 되어있기도 하고, javascript에서 익숙하지 않을뿐이지 사전이라고 많이 사용하네요..!
There was a problem hiding this comment.
저도 번역하면서 같은 생각을 했답니다 ㅎㅎ 😄
좋은 하루 보내세요 :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
translate web/api/window/scrollby in ko
Motivation
Window.scrollBy() page is not translated in ko so i translated
Additional details
Related issues and pull requests