-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pt-br/ru: Replace {{bug}} macro calls with direct links #16898
Conversation
The test failure is due to pre-existing issues in the files and is not a result of these changes. I see that the test has now been made a required test to pass... CC @caugner, we should probably fix all pre-existing issues in the localized content before making that test a required one. |
It appears that it is still marked as a required test? |
It looks like I didn't click on "Save changes". Now it's done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some quotes need to be stripped, my review comments don't include all occurrences.
files/ru/conflicting/web/api/window/beforeunload_event/index.md
Outdated
Show resolved
Hide resolved
This pull request has merge conflicts that must be resolved before it can be merged. |
f1b8a42
to
804b986
Compare
files/ru/web/api/xmlhttprequest_api/using_xmlhttprequest/index.md
Outdated
Show resolved
Hide resolved
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This pull request has merge conflicts that must be resolved before it can be merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approve for pt-BR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approve for Ru. Thanks ❤️
This PR replaces all remaining calls to the
{{bug}}
macro with hard-coded URLs. This removes the last remaining calls to the{{bug}}
macro from all content.