Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pt-br/ru: Replace {{bug}} macro calls with direct links #16898

Merged
merged 4 commits into from
Nov 27, 2023
Merged

Conversation

queengooborg
Copy link
Collaborator

This PR replaces all remaining calls to the {{bug}} macro with hard-coded URLs. This removes the last remaining calls to the {{bug}} macro from all content.

@queengooborg queengooborg requested review from a team as code owners November 10, 2023 11:29
@queengooborg queengooborg requested review from lex111 and clovislima and removed request for a team November 10, 2023 11:29
@github-actions github-actions bot added l10n-ru Issues related to Russian content. l10n-pt-br Issues related to Brazilian Portuguese labels Nov 10, 2023
@queengooborg
Copy link
Collaborator Author

The test failure is due to pre-existing issues in the files and is not a result of these changes. I see that the test has now been made a required test to pass...

CC @caugner, we should probably fix all pre-existing issues in the localized content before making that test a required one.

@caugner
Copy link
Contributor

caugner commented Nov 10, 2023

CC @caugner, we should probably fix all pre-existing issues in the localized content before making that test a required one.

Valid point, I removed tests from the required checks again. (cc @LeoMcA)

@queengooborg
Copy link
Collaborator Author

Valid point, I removed tests from the required checks again.

It appears that it is still marked as a required test?

@caugner
Copy link
Contributor

caugner commented Nov 11, 2023

It appears that it is still marked as a required test?

It looks like I didn't click on "Save changes". Now it's done.

Copy link
Contributor

@caugner caugner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some quotes need to be stripped, my review comments don't include all occurrences.

files/ru/conflicting/web/css/_colon_focus-visible/index.md Outdated Show resolved Hide resolved
files/ru/mozilla/firefox/releases/28/index.md Outdated Show resolved Hide resolved
files/ru/mozilla/firefox/releases/28/index.md Outdated Show resolved Hide resolved
@github-actions github-actions bot added the merge conflicts 🚧 This pull request has merge conflicts that must be resolved. label Nov 16, 2023
Copy link
Contributor

This pull request has merge conflicts that must be resolved before it can be merged.

@github-actions github-actions bot removed the merge conflicts 🚧 This pull request has merge conflicts that must be resolved. label Nov 19, 2023
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions github-actions bot added the merge conflicts 🚧 This pull request has merge conflicts that must be resolved. label Nov 19, 2023
Copy link
Contributor

This pull request has merge conflicts that must be resolved before it can be merged.

@github-actions github-actions bot removed the merge conflicts 🚧 This pull request has merge conflicts that must be resolved. label Nov 19, 2023
Copy link
Collaborator

@josielrocha josielrocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve for pt-BR

Copy link
Member

@sashasushko sashasushko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve for Ru. Thanks ❤️

@queengooborg queengooborg merged commit 3d2a4e8 into main Nov 27, 2023
7 of 8 checks passed
@queengooborg queengooborg deleted the bug-macro branch November 27, 2023 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
l10n-pt-br Issues related to Brazilian Portuguese l10n-ru Issues related to Russian content.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants