Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

es/ja: Replace remaining calls to {{xref_cssvisual}} #16900

Merged
merged 1 commit into from
Nov 16, 2023
Merged

es/ja: Replace remaining calls to {{xref_cssvisual}} #16900

merged 1 commit into from
Nov 16, 2023

Conversation

queengooborg
Copy link
Collaborator

This PR replaces all of the remaining calls to the deprecated {{xref_cssvisual}} with the {{cssxref}} macro it calls within.

@queengooborg queengooborg requested review from a team as code owners November 10, 2023 12:06
@queengooborg queengooborg requested review from JuanVqz and kenji-yamasaki and removed request for a team November 10, 2023 12:06
@github-actions github-actions bot added l10n-ja Issues related to Japanese content. l10n-es Issues related to Spanish content. labels Nov 10, 2023
@queengooborg queengooborg mentioned this pull request Nov 10, 2023
Merged
@github-actions GitHub Actions
Copy link
Contributor

Preview URLs (17 pages)
Flaws (114)

URL: /ja/docs/Web/CSS/-webkit-mask-box-image
Title: -webkit-mask-box-image
Flaw count: 3

  • macros:
    • /ja/docs/Web/CSS/Media/Visual redirects to /ja/docs/Web/CSS/@media
    • /ja/docs/Web/CSS/url() redirects to /ja/docs/Web/CSS/url
  • translation_differences:
    • Differences in the important macros (2 in common of 3 possible)

URL: /es/docs/Web/CSS/border-collapse
Title: border-collapse
Flaw count: 7

  • macros:
    • /es/docs/Web/CSS/separate does not exist
    • /es/docs/Web/CSS/Media/Visual does not exist but fell back to /en-US/docs/Web/CSS/@media
    • /es/docs/Web/CSS/computed%20value does not exist
  • broken_links:
    • Can't resolve /samples/cssref/border-collapse.html
    • Is currently http:// but can become https://
    • Is currently http:// but can become https://
  • translation_differences:
    • Differences in the important macros (0 in common of 6 possible)

URL: /es/docs/Web/CSS/-webkit-mask-composite
Title: -webkit-mask-composite
Flaw count: 7

  • macros:
    • /es/docs/Web/CSS/-webkit-mask-image redirects to /es/docs/Web/CSS/mask-image
    • /es/docs/Web/CSS/Media/Visual does not exist but fell back to /en-US/docs/Web/CSS/@media
    • /es/docs/Web/CSS/mask-composite does not exist but fell back to /en-US/docs/Web/CSS/mask-composite
    • /es/docs/Web/CSS/-webkit-mask redirects to /es/docs/Web/CSS/mask
    • /es/docs/Web/CSS/-webkit-mask-clip redirects to /es/docs/Web/CSS/mask-clip
    • and 2 more flaws omitted

URL: /es/docs/Web/CSS/top
Title: Top
Flaw count: 6

  • macros:
    • /es/docs/Web/CSS/auto does not exist but fell back to /en-US/docs/Web/CSS/width
    • /es/docs/Web/CSS/Media/Visual does not exist but fell back to /en-US/docs/Web/CSS/@media
  • broken_links:
    • Can't resolve /es/CSS/position
    • Is currently http:// but can become https://
    • Is currently http:// but can become https://
  • translation_differences:
    • Differences in the important macros (1 in common of 6 possible)

URL: /es/docs/Web/CSS/border-left-color
Title: border-left-color
Flaw count: 4

  • macros:
    • /es/docs/Web/CSS/Media/Visual does not exist but fell back to /en-US/docs/Web/CSS/@media
    • /es/docs/Web/CSS/border-right-color does not exist but fell back to /en-US/docs/Web/CSS/border-right-color
  • broken_links:
    • Can't resolve /samples/cssref/border.html
  • translation_differences:
    • Differences in the important macros (0 in common of 6 possible)

URL: /es/docs/Web/CSS/border-bottom
Title: border-bottom
Flaw count: 8

  • macros:
    • /es/docs/Web/CSS/Media/Visual does not exist but fell back to /en-US/docs/Web/CSS/@media
    • /es/docs/Web/CSS/computed%20value does not exist
  • broken_links:
    • Can't resolve /es/Guía_de_referencia_de_CSS
    • Can't resolve /samples/cssref/border.html
    • Is currently http:// but can become https://
    • Is currently http:// but can become https://
    • Is currently http:// but can become https://
  • translation_differences:
    • Differences in the important macros (0 in common of 6 possible)

URL: /es/docs/Web/CSS/border-bottom-color
Title: border-bottom-color
Flaw count: 8

  • macros:
    • /es/docs/Web/CSS/Media/Visual does not exist but fell back to /en-US/docs/Web/CSS/@media
    • /es/docs/Web/CSS/computed%20value does not exist
    • /es/docs/Web/CSS/border-right-color does not exist but fell back to /en-US/docs/Web/CSS/border-right-color
  • broken_links:
    • Can't resolve /es/Guía_de_referencia_de_CSS
    • Can't resolve /samples/cssref/border.html
    • Is currently http:// but can become https://
    • Is currently http:// but can become https://
  • translation_differences:
    • Differences in the important macros (0 in common of 6 possible)

URL: /es/docs/Web/CSS/border-bottom-width
Title: border-bottom-width
Flaw count: 12

  • macros:
    • /es/docs/Web/CSS/medium does not exist
    • /es/docs/Web/CSS/Media/Visual does not exist but fell back to /en-US/docs/Web/CSS/@media
    • /es/docs/Web/CSS/computed%20value does not exist
    • /es/docs/Web/CSS/border-left-style does not exist but fell back to /en-US/docs/Web/CSS/border-left-style
    • /es/docs/Web/CSS/border-right-style does not exist but fell back to /en-US/docs/Web/CSS/border-right-style
    • and 1 more flaws omitted
  • broken_links:
    • Can't resolve /es/Guía_de_referencia_de_CSS
    • Can't resolve /samples/cssref/border.html
    • Is currently http:// but can become https://
    • Is currently http:// but can become https://
    • Is currently http:// but can become https://
  • translation_differences:
    • Differences in the important macros (0 in common of 6 possible)

URL: /es/docs/Web/CSS/-webkit-mask-box-image
Title: -webkit-mask-box-image
Flaw count: 7

  • macros:
    • /es/docs/Web/CSS/Media/Visual does not exist but fell back to /en-US/docs/Web/CSS/@media
    • /es/docs/Web/CSS/uri does not exist but fell back to /en-US/docs/Web/CSS/url
    • /es/docs/Web/CSS/-webkit-mask redirects to /es/docs/Web/CSS/mask
    • /es/docs/Web/CSS/-webkit-mask-origin redirects to /es/docs/Web/CSS/mask-origin
    • /es/docs/Web/CSS/-webkit-mask-clip redirects to /es/docs/Web/CSS/mask-clip
    • and 2 more flaws omitted

URL: /es/docs/Web/CSS/visibility
Title: visibility
Flaw count: 5

  • macros:
    • /es/docs/Web/CSS/visible does not exist but fell back to /en-US/docs/Web/CSS/visibility
    • /es/docs/Web/CSS/Media/Visual does not exist but fell back to /en-US/docs/Web/CSS/@media
    • /es/docs/Web/CSS/computed%20value does not exist
  • broken_links:
    • Is currently http:// but can become https://
  • translation_differences:
    • Differences in the important macros (1 in common of 7 possible)

URL: /es/docs/Web/CSS/right
Title: right
Flaw count: 6

  • macros:
    • /es/docs/Web/CSS/auto does not exist but fell back to /en-US/docs/Web/CSS/width
    • /es/docs/Web/CSS/Media/Visual does not exist but fell back to /en-US/docs/Web/CSS/@media
  • broken_links:
    • Can't resolve /es/CSS/position
    • Is currently http:// but can become https://
    • Is currently http:// but can become https://
  • translation_differences:
    • Differences in the important macros (1 in common of 7 possible)

URL: /es/docs/Web/CSS/min-width
Title: min-width
Flaw count: 7

  • macros:
    • /es/docs/Web/CSS/Media/Visual does not exist but fell back to /en-US/docs/Web/CSS/@media
    • /es/docs/Web/CSS/max-width does not exist but fell back to /en-US/docs/Web/CSS/max-width
    • /es/docs/Web/CSS/-moz-box-sizing does not exist but fell back to /en-US/docs/Web/CSS/box-sizing
    • /es/docs/Web/CSS/max-width does not exist but fell back to /en-US/docs/Web/CSS/max-width
  • broken_links:
    • Is currently http:// but can become https://
    • Can't resolve /es/CSS/box_model
  • translation_differences:
    • Differences in the important macros (1 in common of 5 possible)

URL: /es/docs/Web/CSS/max-height
Title: max-height
Flaw count: 7

  • macros:
    • /es/docs/Web/CSS/none redirects to /es/docs/Web/CSS/float
    • /es/docs/Web/CSS/Media/Visual does not exist but fell back to /en-US/docs/Web/CSS/@media
    • /es/docs/Web/CSS/computed%20value does not exist
    • /es/docs/Web/CSS/Modelo%20de%20caja does not exist
    • /es/docs/Web/CSS/-moz-box-sizing does not exist but fell back to /en-US/docs/Web/CSS/box-sizing
  • broken_links:
    • Is currently http:// but can become https://
  • translation_differences:
    • Differences in the important macros (0 in common of 5 possible)

URL: /es/docs/Web/CSS/border-bottom-style
Title: border-bottom-style
Flaw count: 11

  • macros:
    • /es/docs/Web/CSS/none redirects to /es/docs/Web/CSS/float
    • /es/docs/Web/CSS/Media/Visual does not exist but fell back to /en-US/docs/Web/CSS/@media
    • /es/docs/Web/CSS/computed%20value does not exist
    • /es/docs/Web/CSS/border-left-style does not exist but fell back to /en-US/docs/Web/CSS/border-left-style
    • /es/docs/Web/CSS/border-right-style does not exist but fell back to /en-US/docs/Web/CSS/border-right-style
    • and 1 more flaws omitted
  • broken_links:
    • Can't resolve /es/Guía_de_referencia_de_CSS
    • Can't resolve /samples/cssref/border.html
    • Is currently http:// but can become https://
    • Is currently http:// but can become https://
  • translation_differences:
    • Differences in the important macros (0 in common of 6 possible)

URL: /es/docs/Web/CSS/line-height
Title: line-height
Flaw count: 5

  • macros:
    • /es/docs/Web/CSS/normal does not exist but fell back to /en-US/docs/Web/CSS/font-variant
    • /es/docs/Web/CSS/Media/Visual does not exist but fell back to /en-US/docs/Web/CSS/@media
    • /es/docs/Web/CSS/computed%20value does not exist
  • broken_links:
    • Can't resolve /es/docs/Web/CSS/porcentaje
  • translation_differences:
    • Differences in the important macros (3 in common of 6 possible)

URL: /es/docs/Web/CSS/border-spacing
Title: border-spacing
Flaw count: 6

  • macros:
    • /es/docs/Web/CSS/Media/Visual does not exist but fell back to /en-US/docs/Web/CSS/@media
    • /es/docs/Web/CSS/computed%20value does not exist
  • broken_links:
    • Can't resolve /es/CSS/border-collapse
    • Can't resolve /samples/cssref/border-spacing.html
    • Is currently http:// but can become https://
  • translation_differences:
    • Differences in the important macros (0 in common of 6 possible)

URL: /es/docs/orphaned/Web/CSS/ime-mode
Title: ime-mode
Flaw count: 5

  • macros:
    • /es/docs/Web/CSS/auto does not exist but fell back to /en-US/docs/Web/CSS/width
    • /es/docs/Web/CSS/Media/Visual does not exist but fell back to /en-US/docs/Web/CSS/@media
    • /es/docs/Web/CSS/computed%20value does not exist
  • broken_links:
    • Is currently http:// but can become https://
    • Can't resolve /zh_tw/CSS/ime-mode

potappo
potappo approved these changes Nov 11, 2023
View reviewed changes
Copy link
Collaborator

@potappo potappo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for ja

@Graywolf9 Graywolf9 requested review from Graywolf9 and removed request for JuanVqz November 16, 2023 22:21
Graywolf9
Graywolf9 approved these changes Nov 16, 2023
View reviewed changes
Copy link
Contributor

@Graywolf9 Graywolf9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for es , thank you so much !

I think I'm the last one so I'll merge it <3

@Graywolf9 Graywolf9 merged commit b74cef4 into main Nov 16, 2023
7 checks passed
@Graywolf9 Graywolf9 deleted the xref_cssvisual branch November 16, 2023 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Graywolf9 Graywolf9 Graywolf9 approved these changes

@potappo potappo potappo approved these changes

@kenji-yamasaki kenji-yamasaki Awaiting requested review from kenji-yamasaki kenji-yamasaki is a code owner automatically assigned from mdn/yari-content-ja

Assignees
No one assigned
Labels
l10n-es Issues related to Spanish content. l10n-ja Issues related to Japanese content.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@queengooborg @Graywolf9 @potappo