Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[zh-cn]: Correct the link in tutorial of command line #18558

Closed
wants to merge 5 commits into from
Closed

[zh-cn]: Correct the link in tutorial of command line #18558

wants to merge 5 commits into from

Conversation

Kino14910
Copy link
Contributor

@Kino14910 Kino14910 commented Mar 10, 2024 •
edited
Loading

No description provided.

@Kino14910 Kino14910 requested a review from a team as a code owner March 10, 2024 16:36
@Kino14910 Kino14910 requested review from irvin and removed request for a team March 10, 2024 16:36
@github-actions github-actions bot added the l10n-zh Issues related to Chinese content. label Mar 10, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 10, 2024 •
edited
Loading

Preview URLs

Flaws (16)

URL: /zh-CN/docs/Learn/Tools_and_testing/Understanding_client-side_tools/Command_line
Title: 命令行速成课
Flaw count: 16

  • macros:
    • /zh-CN/docs/Learn/Tools_and_testing/Client-side_JavaScript_frameworks/React_interactivity_events_state does not exist but fell back to /en-US/docs/Learn/Tools_and_testing/Client-side_JavaScript_frameworks/React_interactivity_events_state
    • /zh-CN/docs/Learn/Tools_and_testing/Client-side_JavaScript_frameworks/React_interactivity_filtering_conditional_rendering does not exist but fell back to /en-US/docs/Learn/Tools_and_testing/Client-side_JavaScript_frameworks/React_interactivity_filtering_conditional_rendering
    • /zh-CN/docs/Learn/Tools_and_testing/Client-side_JavaScript_frameworks/React_accessibility does not exist but fell back to /en-US/docs/Learn/Tools_and_testing/Client-side_JavaScript_frameworks/React_accessibility
    • /zh-CN/docs/Learn/Tools_and_testing/Client-side_JavaScript_frameworks/React_resources does not exist but fell back to /en-US/docs/Learn/Tools_and_testing/Client-side_JavaScript_frameworks/React_resources
    • /zh-CN/docs/Learn/Tools_and_testing/Client-side_JavaScript_frameworks/Ember_getting_started does not exist but fell back to /en-US/docs/Learn/Tools_and_testing/Client-side_JavaScript_frameworks/Ember_getting_started
    • and 10 more flaws omitted
  • broken_links:
    • Can't resolve /zh-CN/docs/Web/API/WindowOrWorkerGlobalScope/fetch

(comment last updated: 2024-03-11 01:39:59)

@JasonLamv-t JasonLamv-t changed the title Update index.md [zh-cn]: Correct the link in tutorial of command line Mar 11, 2024
yin1999
yin1999 reviewed Mar 11, 2024
View reviewed changes
files/zh-cn/learn/tools_and_testing/understanding_client-side_tools/command_line/index.md

但是，这个 URL 是页面的旧位置。如果你在一个新的浏览器标签中输入它，你将 (最终) 被重定向到[https://developer.mozilla.org/en-US/docs/Web/API/fetch](/zh-CN/docs/Web/API/fetch).
但是，这个 URL 是页面的旧位置。如果你在一个新的浏览器标签中输入它，你将 (最终) 被重定向到[https://developer.mozilla.org/zh-CN/docs/Web/API/fetch](/zh-CN/docs/Web/API/fetch).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
但是，这个 URL 是页面的旧位置。如果你在一个新的浏览器标签中输入它，你将 (最终) 被重定向到[https://developer.mozilla.org/zh-CN/docs/Web/API/fetch](/zh-CN/docs/Web/API/fetch).
但是，这个 URL 是页面的旧位置。如果你在一个新的浏览器标签中输入它，你将 (最终) 被重定向到 [https://developer.mozilla.org/zh-CN/docs/Web/API/fetch](/zh-CN/docs/Web/API/fetch)。

Kino14910 and others added 3 commits March 11, 2024 09:34
yin1999
yin1999 reviewed Mar 11, 2024
View reviewed changes
files/zh-cn/learn/tools_and_testing/understanding_client-side_tools/command_line/index.md
@@ -284,7 +286,7 @@ curl https://developer.mozilla.org/docs/Web/API/fetch -L -I | grep location
输出应该是这样的 (`curl` 首先会输出一些下载计数器之类的东西):

```bash
location: /en-US/docs/Web/API/fetch
location: /zh-CN/docs/Web/API/fetch
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The location given in the example is the actual behavior of the server:

image

yin1999
yin1999 requested changes Mar 11, 2024
View reviewed changes
Copy link
Member

@yin1999 yin1999 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In previous updates to url's local, we specifically skipped this section in the doc because it would make the context of the document inconsistent.

The English document has reorganized this section. I think we should completely synchronize the content instead of just modifying a few links.

Edit:

Left a -1 here to avoid introducing incorrect content

@Kino14910 Kino14910 closed this by deleting the head repository Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yin1999 yin1999 yin1999 requested changes

@JasonLamv-t JasonLamv-t JasonLamv-t requested changes

@irvin irvin Awaiting requested review from irvin irvin is a code owner automatically assigned from mdn/yari-content-zh

Assignees
No one assigned
Labels
l10n-zh Issues related to Chinese content.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Kino14910 @yin1999 @JasonLamv-t