Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(env): update required node engine to v18.18 #21977

Merged
merged 4 commits into from
Jul 29, 2024
Merged

Conversation

OnkarRuikar
Copy link
Contributor

@OnkarRuikar OnkarRuikar requested a review from a team as a code owner June 27, 2024 08:07
@github-actions github-actions bot added the system Infrastructure and configuration for the project label Jun 27, 2024
.nvmrc Outdated Show resolved Hide resolved
@yin1999
Copy link
Member

yin1999 commented Jul 29, 2024

Hey @OnkarRuikar. I think the problem metioned in mdn/yari#11373 would not affect this repo. I've made a test with node v18.0.0, and I found that the min version required by dependencies in this repo could be 18.12.0:

image

And I can install the dependencies when the node version set to v18.12.0:

image


Should we set it to >=18.12.0 instead?

package.json Outdated Show resolved Hide resolved
Copy link
Member

@yin1999 yin1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @OnkarRuikar

@yin1999 yin1999 merged commit 8d122a5 into mdn:main Jul 29, 2024
8 of 9 checks passed
@OnkarRuikar OnkarRuikar deleted the nvm branch July 29, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
system Infrastructure and configuration for the project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants