Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Blob docs, add Blob.type #3929

Merged
merged 6 commits into from
Feb 19, 2022
Merged

Update Blob docs, add Blob.type #3929

merged 6 commits into from
Feb 19, 2022

Conversation

alattalatta
Copy link
Member

  • Markdown
    • 모든 파일에 히스토리가 없습니다. 커밋 하나로 처리했습니다.
  • 내용 업데이트
  • Blob.type 추가

@alattalatta alattalatta requested a review from a team as a code owner January 31, 2022 15:45
@alattalatta alattalatta requested review from cos18 and removed request for a team January 31, 2022 15:45
@github-actions github-actions bot added the l10n-ko Issues related to Korean content. label Jan 31, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jan 31, 2022

Preview URLs

Flaws

URL: /ko/docs/Web/API/Blob
Title: Blob
on GitHub
Flaw count: 10

  • macros:
    • /ko/docs/Web/API/Blob/slice does not exist but fell back to /en-US/docs/Web/API/Blob/slice
    • /ko/docs/Web/API/Blob/arrayBuffer does not exist but fell back to /en-US/docs/Web/API/Blob/arrayBuffer
    • /ko/docs/Web/API/ArrayBuffer does not exist
    • /ko/docs/Web/API/Blob/slice does not exist but fell back to /en-US/docs/Web/API/Blob/slice
    • /ko/docs/Web/API/Blob/stream does not exist but fell back to /en-US/docs/Web/API/Blob/stream
    • and 4 more flaws omitted
  • translation_differences:
    • Differences in the important macros (3 in common of 5 possible)

URL: /ko/docs/Web/API/Blob/size
Title: Blob.size
on GitHub
Flaw count: 1

  • translation_differences:
    • Differences in the important macros (3 in common of 5 possible)

URL: /ko/docs/Web/API/Blob/type
Title: Blob.type
on GitHub
Flaw count: 1

  • translation_differences:
    • Differences in the important macros (3 in common of 5 possible)

URL: /ko/docs/Web/API/Blob/Blob
Title: Blob()
on GitHub
Flaw count: 2

  • macros:
    • /ko/docs/Web/API/ArrayBufferView does not exist but fell back to /en-US/docs/Web/API/ArrayBufferView
    • /ko/docs/Web/API/BlobPropertyBag does not exist

External URLs

URL: /ko/docs/Web/API/Blob
Title: Blob
on GitHub

No new external URLs


URL: /ko/docs/Web/API/Blob/size
Title: Blob.size
on GitHub

No new external URLs


URL: /ko/docs/Web/API/Blob/type
Title: Blob.type
on GitHub

No new external URLs


URL: /ko/docs/Web/API/Blob/Blob
Title: Blob()
on GitHub

No new external URLs

(this comment was updated 2022-02-19 13:54:27.344983)

Copy link
Collaborator

@cos18 cos18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

기여 감사합니다! 리뷰드린 내용 확인 부탁드립니다.

files/ko/web/api/blob/blob/index.md Outdated Show resolved Hide resolved
files/ko/web/api/blob/blob/index.md Show resolved Hide resolved
files/ko/web/api/blob/blob/index.md Outdated Show resolved Hide resolved
files/ko/web/api/blob/index.md Outdated Show resolved Hide resolved
files/ko/web/api/blob/index.md Outdated Show resolved Hide resolved
files/ko/web/api/blob/index.md Outdated Show resolved Hide resolved
files/ko/web/api/blob/index.md Outdated Show resolved Hide resolved
files/ko/web/api/blob/index.md Outdated Show resolved Hide resolved
files/ko/web/api/blob/index.md Outdated Show resolved Hide resolved
files/ko/web/api/blob/type/index.md Show resolved Hide resolved
Copy link
Collaborator

@cos18 cos18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수정하시지 않은 파트에 대해서 커멘트 달아드렸습니다. 확인하시고 커멘트 남겨주시면 최종 머지 진행하겠습니다!

@alattalatta
Copy link
Member Author

alattalatta commented Feb 19, 2022

@cos18 #3929 (comment) 반영했습니다~ USVString은 JS 문자열에 대응돼서 객체 말고 값으로 가져갔습니다.

Copy link
Collaborator

@cos18 cos18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 수고하셨습니다 👍

@cos18 cos18 merged commit 5e61f18 into mdn:main Feb 19, 2022
@alattalatta alattalatta deleted the api/blob branch February 19, 2022 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
l10n-ko Issues related to Korean content.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants