Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): bump required node version to >=18.18 #11373

Merged
merged 2 commits into from
Jul 1, 2024
Merged

Conversation

OnkarRuikar
Copy link
Contributor

Summary

Build fails when node v18 is used.

Problem

Getting following error trying to do yarn install:

fsh$ yarn install
yarn install v1.22.19
[1/5] Validating package.json...
[2/5] Resolving packages...
[3/5] Fetching packages...
error @typescript-eslint/utils@7.14.1: The engine "node" is incompatible with this module. Expected version "^18.18.0 || >=20.0.0". Got "18.17.1"
error Found incompatible module.

The files .nvmrc and package.json are recommending old versions of node.

Solution

Update .nvmrc and package.json files to use v18.18.0.

How did you test this change?

Tried yarn install command before and after the fix.

package.json Show resolved Hide resolved
.nvmrc Outdated Show resolved Hide resolved
@OnkarRuikar OnkarRuikar requested a review from caugner June 27, 2024 08:46
@caugner caugner changed the title fix(env): update required node engine to v18.18 fix(deps): bump required node version to >=v18.18 Jul 1, 2024
@caugner caugner changed the title fix(deps): bump required node version to >=v18.18 fix(deps): bump required node version to >=18.18 Jul 1, 2024
@caugner caugner merged commit 4f6d197 into mdn:main Jul 1, 2024
11 checks passed
@OnkarRuikar OnkarRuikar deleted the nvm branch July 1, 2024 08:43
ferdnyc pushed a commit to ferdnyc/yari that referenced this pull request Jul 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants