Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sidebar is broken for the API/Element page #3119

Closed
wbamberg opened this issue Mar 4, 2021 · 1 comment · Fixed by #3131
Closed

Sidebar is broken for the API/Element page #3119

wbamberg opened this issue Mar 4, 2021 · 1 comment · Fixed by #3131

Comments

@wbamberg
Copy link
Collaborator

wbamberg commented Mar 4, 2021 •
edited
Loading

Reported in Matrix.

See https://developer.mozilla.org/en-US/docs/Web/API/Element: in the sidebar, pages are often (not always) listed twice:

Screen Shot 2021-03-03 at 5 03 55 PM

The sidebar here is built using the APIRef macro, which fetches the list of pages to show using the subpagesExpand API: https://github.com/mdn/yari/blob/main/kumascript/macros/APIRef.ejs#L52. The macro hasn't changed in any suspicious way recently, so perhaps Yari is double-counting some pages here for some reason?
@Elchi3 Elchi3 mentioned this issue Mar 4, 2021
Merged
@Elchi3
Copy link
Member

Elchi3 commented Mar 4, 2021

Sigh. Sorry about this. See #3131

@Ryuno-Ki Ryuno-Ki mentioned this issue Mar 5, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove mixins that have been removed from MDN content Elchi3/yari
2 participants
@Elchi3 @wbamberg