-
Notifications
You must be signed in to change notification settings - Fork 503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove mixins that have been removed from MDN content #3131
Conversation
Also, sidebars do really weird things and we should make them stop |
Oh, so it's this bit: yari/kumascript/macros/APIRef.ejs Lines 98 to 99 in b23b659
? |
Yeah exactly. |
Tiny PR, huge comment. sorry. I understand some of this but not all of it. What it looks like this is doingIt looks like this is doing the following things: Changes in GroupData
Removing interfaces from groups ought to stop that interface from showing up in the sidebar for group-level pages. Changes in InterfaceData
Removing interfaces from Things I understandCurrently, at https://developer.mozilla.org/en-US/docs/Web/API/Document_Object_Model, Also, listing Things I don't understandRemoving
|
Sorry to not have explained this in more details. Basically, there are two messy areas colliding here: mixins and sidebars. It is no fun.
It was correct. However, with the redirect
Yes, it is a mixin and I deleted the page. However, MDN has trouble deleting things. See #2224
I think that's because
I removed this because it is old data. If I remember correctly it is the old name for |
Mixin work is so thankless. Really.
I forgot to remove mixin pages from the infamous InterfaceData and GroupData macros.
This is what is happening: Mixin pages are made redirects to some sensible real interface pages like Element.
Great for readers because they'll land somewhere, but these lovely macros still make calls to get the sub pages and so they can be rendered twice (once from Element, and also from e.g. NonDocumentTypeChildNode which is now a redirect to Element.)
I'll add this to my mixin checklist, so it doesn't happen again.
Closes #3119