Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(release-please): use bootstrap-sha instead of last-release-sha #10414

Merged
merged 1 commit into from
Jan 30, 2024

Conversation

caugner
Copy link
Contributor

@caugner caugner commented Jan 30, 2024

Summary

Problem

Release-please couldn't use last-release-sha on its own:

Error: release-please failed: unable to parse version string: 79980295f3bc209d006d14c8555ac1cbf430edb4

Solution

Use bootstrap-sha instead.


How did you test this change?

We cannot easily test without merging.

@caugner caugner requested a review from a team as a code owner January 30, 2024 11:11
Copy link
Contributor Author

@caugner caugner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self-approval.

@caugner caugner merged commit 1d86b6c into main Jan 30, 2024
11 checks passed
@caugner caugner deleted the fix-release-please-use-bootstrap-sha branch January 30, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant