enhance(telemetry): enable Glean automatic page load events #10983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This additionally removes the `max_events` option (we already default to 1 in recent versions) and changes the location of the logging enabled/disabled so that live debugging can happen without the logging being overwritten.
Dexterp37
commented
Apr 23, 2024
| } | ||
| Glean.setLogPings(GLEAN_DEBUG); |
There was a problem hiding this comment.
I'm not sure what the intent was here, but we currently support turning on/off debugging from the browser console. By having this line here, whatever we set from the console gets overridden by GLEAN_DEBUG
There was a problem hiding this comment.
@Dexterp37 I'm curious, how can I enable debugging from the console?
There was a problem hiding this comment.
@caugner good question! By opening the browser console, you can do window.Glean.set* (you have 3 functions there that you can use to live debug production things as well!)
caugner
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This additionally removes the
max_eventsoption (we already default to 1 in recent versions) and changes the location of the logging enabled/disabled so that live debugging can happen without the logging being overwritten.Summary
Problem
Solution
Screenshots
Before
After
How did you test this change?