Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(spas): set canonical url #11033

Merged
merged 8 commits into from
Apr 30, 2024
Merged

fix(spas): set canonical url #11033

merged 8 commits into from
Apr 30, 2024

Conversation

caugner
Copy link
Contributor

@caugner caugner commented Apr 29, 2024

Summary

(MP-1095)

Problem

Our static pages incorrectly reference https://developer.mozilla.org/ as their canonical URL.

Solution

Correctly set the canonical URL on static pages.


Screenshots

Before

After


How did you test this change?

  1. Ran yarn tool spas and verified the index.html in client/build.
  2. Deployed to stage and verified these pages:

@caugner caugner marked this pull request as ready for review April 30, 2024 12:11
@caugner caugner requested a review from a team as a code owner April 30, 2024 12:11
Copy link
Contributor

@fiji-flo fiji-flo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to yolo this as we're replacing this in #10953

@caugner caugner merged commit 01db757 into main Apr 30, 2024
13 checks passed
@caugner caugner deleted the MP-1095-fix-canonical-urls branch April 30, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants