chore(redirects): remove retiredLocale parameter #11148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
redirects
caugner
force-pushed
the
MP-1112-remove-retiredLocale-param
branch
from
41b2b3c
to
a624e6f
Compare
fiji-flo
reviewed
May 29, 2024
This is part of our SEO effort, reducing the number of duplicate URLs.
We could just remove the redirect, but if nothing links/redirects to |
ferdnyc
pushed a commit
to ferdnyc/yari
that referenced
this pull request
Jul 13, 2024
We have been redirecting retired locales to `en-US` with a `?retiredLocale=XX` parameter to show a retirement message, but this is no longer useful, as those locales have been retired for more than 1.5 years, so we remove this behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Problem
We redirect retired locales to
en-USwith a?retiredLocale=XXparameter to show a retirement message, but this is no longer useful, as those locales have been retired for more than 1.5 years.Solution
Remove the retirement message and the
retiredLocaleparameter.How did you test this change?
Ran
npm i && npm startin/cloud-functionand verified thathttp://localhost:5100/ar/redirects tohttp://localhost:5100/en-US/, nothttp://localhost:5100/en-US/?retiredLocale=ar.