Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(macros/WebExtAllExamples): update zh-* translation #11831

Merged
merged 5 commits into from
Oct 16, 2024

Conversation

skyclouds2001
Copy link
Contributor

@skyclouds2001 skyclouds2001 commented Sep 19, 2024

Summary

part of the mdn/translated-content#13881

/cc @yin1999 @JasonLamv-t @jasonren0403

Problem

Solution


Screenshots

Before

image

After

image


How did you test this change?

observe the develop result

@github-actions github-actions bot added the macros tracking issues related to kumascript macros label Sep 19, 2024
@skyclouds2001 skyclouds2001 changed the title add i18n chore(macros/WebExtAllExamples): update zh-* translation Sep 19, 2024
@skyclouds2001 skyclouds2001 marked this pull request as ready for review September 19, 2024 14:34
@skyclouds2001 skyclouds2001 requested a review from a team as a code owner September 19, 2024 14:34
Copy link
Member

@JasonLamv-t JasonLamv-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Member

@yin1999 yin1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you 🙏

Copy link
Contributor

@jasonren0403 jasonren0403 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jasonren0403
Copy link
Contributor

/ping @mdn/core-dev for another look 👀

addtionally, the 'Compare bundle size' check seems unrelevant for this commit

@PassionPenguin
Copy link
Contributor

/ping @mdn/core-dev for another look 👀

addtionally, the 'Compare bundle size' check seems unrelevant for this commit

same here #11606 (comment) 🤔

@caugner caugner merged commit e0c5575 into mdn:main Oct 16, 2024
13 checks passed
@skyclouds2001 skyclouds2001 deleted the WebExtAllExamples branch October 16, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
macros tracking issues related to kumascript macros
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants