Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(macros/LearnSidebar): add translate HTML, CSS section #11839

Closed
wants to merge 1 commit into from

Conversation

gurezo
Copy link
Contributor

@gurezo gurezo commented Sep 21, 2024

Summary

@hmatrjp @potappo , mdn-yari-ja

please review for this pull request

Problem

  • There is no Japanese translation yet

English pages

Japanese pages

section before after
HTML スクリーンショット 2024-09-21 13 49 01
CSS スクリーンショット 2024-09-21 13 55 26

Solution

translate japanese for LearnSidebar.ejs

NOTICE

@mdn/core-dev

Please merge once mdn-yari-ja is approved.

Before

  • There is no Japanese translation yet

After

  • tranlate japanese for LearnSidebar.ejs

@gurezo gurezo requested a review from a team as a code owner September 21, 2024 05:10
@github-actions github-actions bot added the macros tracking issues related to kumascript macros label Sep 21, 2024
@gurezo gurezo force-pushed the issues/isuue/790 branch 3 times, most recently from 47739ef to ecc4ed9 Compare September 21, 2024 05:18
@gurezo
Copy link
Contributor Author

gurezo commented Sep 21, 2024

didn't pass CI
i'll remake prs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
macros tracking issues related to kumascript macros
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant