Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

smartlink to fallback on en-US #3133

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions client/src/document/index.scss
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,12 @@
}
}

.only-in-en-us {
span {
font-size: $small-font-size;
}
}

.article {
padding: ($base-spacing / 2) $base-spacing $base-spacing;

Expand Down
21 changes: 21 additions & 0 deletions kumascript/src/api/web.js
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,27 @@ module.exports = {
page.url + hrefhash
}"${titleAttribute}${flawAttribute}>${content}</a>`;
}
if (!href.toLowerCase().startsWith("/en-us/")) {
// Before flagging this as a broken-link flaw, see if it's possible to
// change it to the en-US URL instead.
const hrefSplit = href.split("/");
hrefSplit[1] = "en-US";
const enUSPage = this.info.getPageByURL(hrefSplit.join("/"));
if (enUSPage.url) {
// But it's still a flaw. Record it so that translators can write a
// translated document to "fill the hole".
flaw = this.env.recordNonFatalError(
"broken-link",
`${hrefpath} does not exist but fallbacked on ${enUSPage.url}`
peterbe marked this conversation as resolved.
Show resolved Hide resolved
);
flawAttribute = ` data-flaw-src="${util.htmlEscape(flaw.macroSource)}"`;
return (
'<a class="only-in-en-us" ' +
'title="Currently only available in English" ' +
`href="${enUSPage.url}"${flawAttribute}>${content} <span>(en-US)</span></a>`
);
}
}
flaw = this.env.recordNonFatalError(
"broken-link",
`${hrefpath} does not exist`
Expand Down