test Flaws dashboard in CI #3181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fiji-flo
approved these changes
Mar 10, 2021
| yarn test:testing developing | ||
|
|
||
| - name: Debug server's stdout and stderr if tests failed | ||
| if: failure() |
This was referenced Mar 11, 2021
peterbe
added a commit
to peterbe/yari
that referenced
this pull request
Jun 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm killing two birds with one stone here.
First of all, it doesn't have to be extensive (and opening is better than doing nothing) but at least this checks that the Flaws Dashboard is there and that it can be opened.
Second of all, I like this use of
if: failure()instead of a hackybashtrick looking for exit codes.