Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Japanese Translations #4696

Merged
merged 6 commits into from
Jan 26, 2022
Merged

Added Japanese Translations #4696

merged 6 commits into from
Jan 26, 2022

Conversation

hmatrjp
Copy link
Contributor

@hmatrjp hmatrjp commented Sep 18, 2021

This is to add two Japanese translations for messages to translated pages.
At last I could make a PR based on 'pure signed' commit.

escattone
escattone suggested changes Sep 18, 2021
View reviewed changes
Copy link
Contributor

@escattone escattone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @hmatrjp! Just needs some minor adjustments. Please run yarn prettier-format as well.

client/src/document/molecules/localized-content-note/index.tsx Outdated Show resolved Hide resolved
client/src/document/molecules/localized-content-note/index.tsx Outdated Show resolved Hide resolved
@hmatrjp @escattone
Update client/src/document/molecules/localized-content-note/index.tsx
2ce2dfe 
I understand this phrase is not for ja locale. Sorry for my slow response.

Co-authored-by: Ryan Johnson <escattone@gmail.com>
@schalkneethling schalkneethling mentioned this pull request Jan 18, 2022
Closed
30 tasks
@schalkneethling schalkneethling self-requested a review January 19, 2022 10:16
@schalkneethling schalkneethling self-assigned this Jan 19, 2022
@schalkneethling schalkneethling added the 🧑‍🤝‍🧑 community contributions by our wonderful community label Jan 19, 2022
@schalkneethling schalkneethling added this to the Sprint 2: Platform milestone Jan 19, 2022
schalkneethling
schalkneethling approved these changes Jan 26, 2022
View reviewed changes
Copy link

@schalkneethling schalkneethling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @hmatrjp 🎉

@schalkneethling schalkneethling merged commit 298f3b2 into mdn:main Jan 26, 2022
@hmatrjp hmatrjp deleted the japanese branch May 18, 2024 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@escattone escattone escattone requested changes

@schalkneethling schalkneethling schalkneethling approved these changes

Assignees

@schalkneethling schalkneethling

Labels
🧑‍🤝‍🧑 community contributions by our wonderful community
Projects
Yari Platform Engineering
Status: Done
Milestone
Sprint 2: Platform
Development

Successfully merging this pull request may close these issues.
3 participants
@hmatrjp @escattone @schalkneethling