Firefox sidebar changes #5672
Merged
Firefox sidebar changes #5672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove Firefox internals menu * Remove Building and contributing menu * Add link to Experimental features * Update Firefox developer release notes text * Make the above changes for all languages
3 tasks
|
Looks great to me @dipikabh 🙌 - I'll let @schalkneethling merge tho as he'll be more familiar with the changes :) |
|
@dipikabh, for future reference, pull requests to Yari need commits to be signed. See here for more info: https://docs.github.com/articles/about-gpg/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #5096.
Thanks @schalkneethling for your time in helping me make these changes!
Problem
Non-working links under
Firefox internalsandBuilding and contributingSolution
As suggested in the issue, replaced the two menus
Firefox internalsandBuilding and contributingwithFirefox documentation(see After screenshot), which now links to https://firefox-source-docs.mozilla.org/.In addition, the following changes have been made:
Firefox developer release notes(see Before screenshot) toFirefox releases(see After screenshot)Firefox developer release notestoFirefox release notes for developers[title on landing page needs to be updated. I'll submit a separate PR on mdn/content.] - Update title of FF release landing page content#14010Experimental features in Firefox(see After screenshot)Replicated all the above changes in other language sections (which will require translation).
Screenshots
Before
After
How did you test this change?
yarn dev.