feat(macros): add XsltSidebar for XSLT pages #9021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caugner
changed the title
caugner
changed the title
|
Thank you, @caugner 🙏🏻 |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves the XSLT ref macro to use the same structure as the
GlossarySidebarmacro.Problem
There are no / poor sidebars on XSLT pages. Currently, it uses an
xsltrefmacro which renders a few links on some sub-pages in a kind of 'breadcrumb' style.Solution
This macro
XsltSidebarwould deprecate the usage ofxsltrefand add sidebars to all sub-pages under that technology category.If this pull request lands, I would remove usage of
{{xsltref}}from content and push to delete this macro when unused in all locales.Screenshots
Before
After
How did you test this change?
localhost with
yarn && yarn dev