Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update minimum node version from 18.0 to 18.16 #9384

Merged
merged 1 commit into from
Jul 25, 2023
Merged

Conversation

LeoMcA
Copy link
Member

@LeoMcA LeoMcA commented Jul 25, 2023

Summary

Problem

some versions prior to 18.16 were causing ts-node to raise an error: RangeError: Maximum call stack size exceeded

Solution

bump minimum engine version in package.json


How did you test this change?

I've been using node 18.16 for months locally with no problems

some versions prior to 18.16 were causing ts-node to raise an error:
`RangeError: Maximum call stack size exceeded`
@LeoMcA LeoMcA requested a review from bsmth July 25, 2023 11:26
Copy link
Member

@bsmth bsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirming this version was needed to get builds running for me.

Previously (node 18.0.0)

$ ts-node tool/cli.ts optimize-client-build
TypeError [ERR_UNKNOWN_FILE_EXTENSION]: Unknown file extension ".ts" for /.../yari/tool/cli.ts
    at new NodeError (node:internal/errors:405:5)
    at Object.getFileProtocolModuleFormat [as file:] (node:internal/modules/esm/get_format:99:9)
    at defaultGetFormat (node:internal/modules/esm/get_format:142:36)
    at defaultLoad (node:internal/modules/esm/load:91:20)
    at nextLoad (node:internal/modules/esm/hooks:733:28)
    at load (/.../yari/node_modules/ts-node/dist/child/child-loader.js:19:122)
    at nextLoad (node:internal/modules/esm/hooks:733:28)
    at Hooks.load (node:internal/modules/esm/hooks:377:26)
    at MessagePort.handleMessage (node:internal/modules/esm/worker:168:24)
    at [nodejs.internal.kHybridDispatch] (node:internal/event_target:778:20) {
  code: 'ERR_UNKNOWN_FILE_EXTENSION'
}

with 18.16:

nvm use 18.16
# Now using node v18.16.1 (npm v9.5.1)
yarn && yarn dev
yarn install v1.22.19
[1/5] 🔍  Validating package.json...
...
$ ts-node tool/cli.ts optimize-client-build
(node:11694) ExperimentalWarning: Import assertions are not a stable feature of the JavaScript language. Avoid relying on their current behavior and syntax as those might change in a future version of Node.js.
(Use `node --trace-warnings ...` to show where the warning was created)
(node:11694) ExperimentalWarning: Importing JSON modules is an experimental feature and might change at any time
info: Hashed 4 files in client/build/index.html

@LeoMcA LeoMcA merged commit efbeb7d into main Jul 25, 2023
14 checks passed
@LeoMcA LeoMcA deleted the min-node-18.16 branch July 25, 2023 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants